Repository navigation
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
@remeio thanks for the PR but there are no tests that showcase what the code has changed. We can't consider the PR until you amend it with additional unit tests. |
snicoll
added
the
status: waiting-for-feedback
…nal array should be [[[]]]
Contributor
Author
|
@snicoll Hi，I had add the test case for list of 3-dimensional array like I think the default 3-dimensional array should be You can see the test method: Look forward to your reply. |
spring-projects-issues
added
status: feedback-provided
rstoyanchev
added
the
in: core
snicoll
changed the title
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Feb 5, 2025
snicoll
added a commit
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve TODO:
TODO - only handles 2-dimensional arrays.For method
org.springframework.beans.AbstractNestablePropertyAccessor#newValue:typeisInteger[][][].class, it will return a 2-dimensional array instance like[[]].After this PR, this method support handling multidimensional arrays:
typeisInteger[][][].class, it will return a 3-dimensional array instance like[[[]]].But actually, this final behavior is correct before this PR. For example:
org.springframework.beans.BeanWrapperAutoGrowingTests#getPropertyValueAutoGrow3dArrayhad passed.So I just fix this method
newValue.