Skip to content

Fix MSSQL's default username - #7238

Merged
eddumelendez merged 1 commit into
testcontainers:mainfrom
Eng-Fouad:mssql-username-fix
Jul 4, 2023
Merged

eddumelendez merged 1 commit into
testcontainers:mainfrom
Eng-Fouad:mssql-username-fix

Conversation

@Eng-Fouad

Copy link
Copy Markdown
Contributor

Fixes #7237

If MSSQL_COLLATION is set to a collation with case-sensetive (_CS not _CI), the username SA will fail to login to DB, as sa is the correct username.

@eddumelendez

eddumelendez commented Jul 4, 2023 •

Copy link
Copy Markdown
Member

According to the docs, the username is sa. Also, the default collation is SQL_Latin1_General_CP1_CI_AS which is case insensitive, performing SELECT SERVERPROPERTY('COLLATION').

@eddumelendez eddumelendez added this to the next milestone Jul 4, 2023
@eddumelendez
eddumelendez merged commit a00d048 into testcontainers:main Jul 4, 2023
@Eng-Fouad
Eng-Fouad deleted the mssql-username-fix branch July 4, 2023 21:49
@eddumelendez

Copy link
Copy Markdown
Member

Thanks for your contribution, @Eng-Fouad !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Default MSSQL username is sa not SA

2 participants