Skip to content

Add dependabot - #2025

Merged
dearchap merged 1 commit into
urfave:mainfrom
mrueg:add-dependabot
Feb 8, 2025
Merged

dearchap merged 1 commit into
urfave:mainfrom
mrueg:add-dependabot

Conversation

@mrueg

@mrueg mrueg commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • feature

What this PR does / why we need it:

Adds a dependabot configuration for automated dependency and github workflow updates.

Which issue(s) this PR fixes:

None, let me know if I need to create one first.

@mrueg
mrueg requested a review from a team as a code owner December 3, 2024 09:54

@Juneezee Juneezee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@yassinebenaid yassinebenaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartekpacia

Copy link
Copy Markdown
Member

Honestly, I don't see a need for it. I always find dependabots warnings to be annoying and not useful.

Also, this module has no dependencies (aside from some utilities for testing), and we aim to keep it this way.

I'm against.

@abitrolly

Copy link
Copy Markdown
Contributor

-1 on dependabot too. It pollutes search results with irrelevant hits, and mailbox with too much noise.

@mrueg

mrueg commented Dec 3, 2024 •

Copy link
Copy Markdown
Contributor Author

If spam is a concern, we can limit the number of PRs it's opening.
As the project has only few dependencies, dependabot will likely open one PR/month.

It also ensures that the github workflows are using their latest actions, which I think is a benefit to ensure that the work flow stays working and eventually saves you from spending time on upgrading it yourselves.

@bartekpacia

Copy link
Copy Markdown
Member

We don't have many GitHub Actions workflow files, and we only use first-party actions from GitHub, and as of now, they're all on the latest version.

Thank you for this PR and I appreciate enthusiasm, but I'm still against (just my opinion. I'm curious what other maintainers think).

@dearchap
dearchap merged commit 0d4d507 into urfave:main Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants