Repository navigation
Action never failed even if error level issues are detected & fail_on_error is set to true #103
Description
I have the level set to error for my custom vocab, and substitution. When running the GitHub Action, vale report the issues with the proper error level. I also have fail_on_error set to true. No matter these, the action always succeed, and never fail. Here's the .vale.ini for reference.
I assume I either miss something, didn't use the argument properly or it's a bug. Any idea what is happening here?
Activity
karl-johan-grahn commentedon Aug 11, 2023
@jdkato any idea?
fharper commentedon Aug 23, 2023
Seems like it may be a reviewdog issue, and not vale since it's a reviewdog option.
If I'm not wrong, you can close this issue. I posted my workaround in the reviewdog issue reviewdog/reviewdog#1408
make GitHub Action Syntax Check fail when vale find issues
make GitHub Action Syntax Check fail when vale find issues
jdkato commentedon Aug 2, 2026
Your workflow runs
on: [push], and the action's default reporter is PR-only. The pinned reviewdog (0.17.0) returned early on any non-PR event —reviewdog: this is not PullRequest build— so nothing was reported and nothing failed, regardless offail_on_error.Reproduced with your config, then re-run on the version the action now installs:
Fixed on
refreshby the reviewdog upgrade, along with a separatefail_on_errorfix (#84). Until it ships,reporter: github-checkworks on push events.fharper commentedon Aug 5, 2026
Thanks for the reply, but I went another way since it's an old issue. Hopefully the answer will be useful to others :)