Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

refactor(typescript): noImplicitAny for Subscription test file - #534

Merged
JustinBeckwith merged 2 commits into
googleapis:masterfrom
praveenqlogic:nodejs-pubsub-tb-dev-noImplicitAny
Mar 11, 2019
Merged

JustinBeckwith merged 2 commits into
googleapis:masterfrom
praveenqlogic:nodejs-pubsub-tb-dev-noImplicitAny

Conversation

@praveenqlogic

Copy link
Copy Markdown
Contributor

Fixes #313 (it's a good idea to open an issue first for discussion)

All files in test, src and system-test folder is done!

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2019
@praveenqlogic
praveenqlogic force-pushed the nodejs-pubsub-tb-dev-noImplicitAny branch 2 times, most recently from 52ced58 to dfcdc80 Compare March 8, 2019 08:18
@codecov

codecov Bot commented Mar 8, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #534 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          16       16           
  Lines         965      965           
  Branches       86       86           
=======================================
  Hits          915      915           
  Misses         42       42           
  Partials        8        8
Impacted Files Coverage Δ
src/subscription.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955ef5f...bb5292b. Read the comment docs.

Comment thread test/subscription.ts Outdated
Comment thread test/subscription.ts
@praveenqlogic
praveenqlogic force-pushed the nodejs-pubsub-tb-dev-noImplicitAny branch 2 times, most recently from 41b4b4b to 8fd0b60 Compare March 11, 2019 07:26
@praveenqlogic
praveenqlogic force-pushed the nodejs-pubsub-tb-dev-noImplicitAny branch from 8fd0b60 to bb5292b Compare March 11, 2019 08:40
@JustinBeckwith
JustinBeckwith merged commit 227d63c into googleapis:master Mar 11, 2019
feywind pushed a commit to feywind/nodejs-pubsub that referenced this pull request Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants