DiffRowGenerator replaces < and >

Expected Behavior

DiffRowGenerator would leave < and > the way they are

Actual Behavior

DiffRowGenerator replaces < and > with their html entities.

Steps to Reproduce the Problem

Run DiffRowGenerator.create().generateDiffRows(List.of("<"), List.of("<"))
Observe that the resulting String has < instead of <

Specifications

Version: 4.0
Platform: Linux
Subsystem:

Using reportLinesUnchanged is not an option since that means tags are missing if an entire line is added/deleted. Having something like replaceSomeHTMLEntities with default true but optionally disableable would be nice, or being able to supply a general string normalisation function.

If needed/wanted I can PR this.

I see. Let me think about a proper solution. Maybe it is time to provide a normalization hook into java-diff-utils. There the HTML entities are replaced in addition to tabs.

I introduced the possibility to modify the used line normalizer. This should provide you with a tool to achieve what you want.

Look at:

java-diff-utils/src/test/java/com/github/difflib/text/DiffRowGeneratorTest.java

Line 401 in a8d968c

.lineNormalizer(str -> str.replace("\t", " "))

Why this is not available in the maven repo, I'm using the following dependency:
<dependency> <groupId>io.github.java-diff-utils</groupId> <artifactId>java-diff-utils</artifactId> <version>4.0</version> </dependency>

Don't know. I will look into it.

The issue was closed after release 4.0 was created. You have to use 4.1-SNAPSHOT. The release is delayed due to the problematic new unified diff parser and writer. I don't want to put it into a release.

Why this 4.1-SNAPSHOT is not available in maven repo to include in my project. What can you suggest?

Hmm. Maybe I never deployed it?

4.1-SNAPSHOT is deployed.

Snapshots are deployed at sonatype.

How I can include this snapshot in my pom.xml?

Ok, found it, jfyi, include the following in your pom.xml:

 <profiles>
    <profile>
        <id>allow-snapshots</id>
        <activation><activeByDefault>true</activeByDefault></activation>
        <repositories>
            <repository>
                <id>snapshots-repo</id>
                <url>https://oss.sonatype.org/content/repositories/snapshots</url>
                <releases><enabled>false</enabled></releases>
                <snapshots><enabled>true</enabled></snapshots>
            </repository>
        </repositories>
    </profile>
</profiles>

Navigation Menu

Repository navigation

DiffRowGenerator replaces < and > #41

Expected Behavior

Actual Behavior

Steps to Reproduce the Problem

Specifications

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

DiffRowGenerator replaces < and > #41

Description

Expected Behavior

Actual Behavior

Steps to Reproduce the Problem

Specifications

Activity

wumpz commented on May 7, 2019

wumpz commented on May 7, 2019

codebusta commented on Sep 19, 2019

wumpz commented on Sep 19, 2019

wumpz commented on Sep 20, 2019

codebusta commented on Sep 20, 2019

wumpz commented on Sep 21, 2019

wumpz commented on Sep 21, 2019

wumpz commented on Sep 21, 2019

codebusta commented on Sep 24, 2019

codebusta commented on Sep 24, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions