Repository navigation
Remove send - #135
Merged
Merged
Remove send#135
Conversation
Member
|
This one relates to #62. I did test locally and ran into this error via a <!doctype html>
<html lang="en">
<video src="demo.mp4"></video>
</html>that does work in v3.0.0-alpha.8 |
Contributor
Author
|
Okay! Yeah this needs a little more manual testing, and I'll see if I can create a unit test that catches that condition. |
Member
|
Maybe #141 might solve this a little cleaner! |
Contributor
Author
|
Okay, put some polish and additional testing into it! |
Member
|
Shipping with v3.0.0 (and v3.0.0-alpha.11) |
Member
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code used
send, but only for content-range requests. send is a pretty deep dependency, and not used very much.https://node-modules.dev/chart/treemap#install=@11ty/eleventy-dev-server
This PR ports the relevant parts to eleventy-dev-server directly. Eliminates 409kb and 17 dependencies. I think the one question mark is whether this needs to adapt send's
content-typesupport or media content.