Xcode 14.3 fix: Pass the -f option when resolving the path to the symlinked source. by clindsay3 · Pull Request #11828 · CocoaPods/CocoaPods

clindsay3 · 2023-03-23T08:49:44Z

🌈

Fixes the issue where archives fail when using Xcode 14.3. #11808

Xcode 14.3 is now using a relative path in its symlink for frameworks. Without the -f flag, this relative path would be evaluated relative to the working directory of the script being executed, instead of relative to the framework symlink itself. With the -f flag, it resolves that relative path and returns the full path to the source.

bundle exec rake spec failed, but it looks like maybe just because there were changes? Snapshot testing maybe? Also, it might make sense to add a test case to handle this scenario, but I don't know CocoaPods well enough to know what to add or where.

rake.txt

Fixes the issue where archives fail when using Xcode 14.3. Xcode 14.3 is now using a relative path in its symlink for frameworks. Without the -f flag, this relative path would be evaluated relative to the working directory of the script being executed, instead of relative to the framework symlink itself. With the -f flag, it resolves that relative path and returns the full path to the source.

ehagerty

Chip: Apple M1 Max
Memory: 64 GB
macOS: 13.4 Beta (22F5027f)

Hi, forgive me if this is the wrong way to suggest it, but in embed_frameworks_script.rb I needed to change your use of readlink to the alternative greadlink which is installed via Brew with coreutils and which by default isn't aliased in place of readlink. Also, when building for macos, the script Pods-Runner-frameworks.sh also needs to use greadlink but it required me to use the full path to the binary whereas in embed_frameworks_script.rb it only required the binary name. By using the fully qualified binary in embed_frameworks_script.rb, it then generates that into Pods-Runner-frameworks.sh so I assume that is the only place that needs a change (if I am right at all in the first place).

gali8 · 2023-03-30T17:54:32Z

+1

holyavkin · 2023-03-30T18:26:01Z

consider renaming the PR and adding a prefix:
Xcode 14.3 fix:

clindsay3 · 2023-03-30T22:04:47Z

Chip: Apple M1 Max Memory: 64 GB macOS: 13.4 Beta (22F5027f)

Hi, forgive me if this is the wrong way to suggest it, but in embed_frameworks_script.rb I needed to change your use of readlink to the alternative greadlink which is installed via Brew with coreutils and which by default isn't aliased in place of readlink. Also, when building for macos, the script Pods-Runner-frameworks.sh also needs to use greadlink but it required me to use the full path to the binary whereas in embed_frameworks_script.rb it only required the binary name. By using the fully qualified binary in embed_frameworks_script.rb, it then generates that into Pods-Runner-frameworks.sh so I assume that is the only place that needs a change (if I am right at all in the first place).

Thanks for the suggestion! What did greadlink do that readlink -f didn't?

clindsay3 · 2023-03-30T22:18:10Z

Hey @dnkoutso sorry to bug you, but this seems like a pretty urgent fix now that Xcode 14.3 is out, and you seem like the author of a bunch of recent commits. Are you able to take a look at this PR, or suggest someone I could reach out to?

ehagerty · 2023-03-31T08:15:05Z

Chip: Apple M1 Max Memory: 64 GB macOS: 13.4 Beta (22F5027f)
Hi, forgive me if this is the wrong way to suggest it, but in embed_frameworks_script.rb I needed to change your use of readlink to the alternative greadlink which is installed via Brew with coreutils and which by default isn't aliased in place of readlink. Also, when building for macos, the script Pods-Runner-frameworks.sh also needs to use greadlink but it required me to use the full path to the binary whereas in embed_frameworks_script.rb it only required the binary name. By using the fully qualified binary in embed_frameworks_script.rb, it then generates that into Pods-Runner-frameworks.sh so I assume that is the only place that needs a change (if I am right at all in the first place).

Thanks for the suggestion! What did greadlink do that readlink -f didn't?

Hi @chrisvasselli i should first thank you for all your work to find this in the first place! using readlink gives an error saying it doesn't know what to do with the -f option, although humorously it then says you could try the -f option... I recalled reading somewhere about the old school readlink command being not quite the same as the greadlink command on the mac so tried it and it ran to completion. I apologise if I've got the wrong end of the stick in making this suggestion, but did want to help others get past the error - as you did.

chamodanethra · 2023-03-31T09:33:51Z

  if [ -L "${source}" ]; then
    echo "Symlinked..."
-    source="$(readlink "${source}")"
+    source="$(readlink -f "${source}")"


This solution is working. I used this workaround for a Flutter project running on 3.7.7.
Thanks, @chrisvasselli

good job bro. Thanks!

This looks great. We have been dead in getting our pipeline fixed with Xcode 14.3. I hope this PR gets merged soon!

Hi, I cant fix it with my Flutter project. Could you help me please?

Hey nickjun03,

Hi, I cant fix it with my Flutter project. Could you help me please?

I managed to solve the issue by doing the following:

Download the cocoapods repository and extract it in a folder

make the change in embed_frameworks_script.rb as shown above

Follow the steps for 'Set up a local dev copy of CocoaPods' here : https://guides.cocoapods.org/using/unreleased-features . The real world walk through is very helpful. I did not have to perform 'git checkout swift' by the way. If you are missing bundle, you can install it by: sudo gem install bundler:2.3.26

In your Flutter's ios folder, you can perform pod deintegrate , delete podfile.lock,

I had to ensure that the iOS development version needs to be at least 9.0. So I edit the last block of Podfile to be:

post_install do |installer| installer.pods_project.targets.each do |target| flutter_additional_ios_build_settings(target) end installer.generated_projects.each do |project| project.targets.each do |target| target.build_configurations.each do |config| if config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'].to_f < 9.0 config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '11.0' end end end end end

Then do pod install but with the local installation, like this example: /Users/orta/spiel/ruby/CocoaPods/bin/pod install

Then, perform Archive (DO NOT Run in Flutter before that! That will re-do pod install with the system's Pod and negate Step 6.)

I hope this helps!

Flutter 3.7.10 has fixed this: flutter/flutter#123890

upgrade Flutter 3.7.10 solution for my

Doesn't work in some cases:
flutter/flutter#124081 (comment)

this works after spending days Thanks !!!! for flutter edit find file called
Pods-Runner-frameworks.sh
and then search for this

source="$(readlink "${source}")"

and add the -f

Enjoy <3

Thank you soo much. Works like a charm.

fivegreenapples · 2023-03-31T19:55:02Z

@chrisvasselli I appreciate your work on this. Saved me a ton of time. Thanks

dnkoutso · 2023-03-31T20:08:31Z

Running CI might need integration specs update.

clindsay3 · 2023-04-01T01:49:28Z

@dnkoutso thanks for taking a look. Created a PR for the specs update, and added an entry to the changelog.

CocoaPods/cocoapods-integration-specs#341

clindsay3 · 2023-04-01T01:50:21Z

@ehagerty the correct option to pass is -f not -r, did you try that?

geminiwen · 2023-04-01T10:15:47Z

meet the same issue on Xcode 14.3 with flutter

maccman · 2023-04-01T14:18:05Z

Just ran into this!

concernedrat · 2023-04-01T14:41:07Z

Ran into this with Xcode 14.3 and Flutter today

arnab · 2023-04-01T17:15:29Z

I’m pretty sure anyone running XCode 14.3 would run into this problem.

I suggest just subscribing to this issue instead of commenting on it (unless you have more insights into the problem).

Then the emails/notifications from this issue (which go to all subscribers) will be more useful (and about actual progress/fix).

dnkoutso · 2023-04-01T18:40:03Z

@chrisvasselli I merged the integration specs PR can you update the submodule here and then push? It should go green.

samueldeschamps · 2023-04-01T19:42:20Z

Ran into the same issue on Xcode 14.3 with Flutter...
The bad luck was somehow Xcode just updated to 14.3 in my Mac without asking me, breaking with all my Flutter projects.

clindsay3 · 2023-04-01T23:32:15Z

@dnkoutso done.

serbixote · 2023-04-02T13:36:22Z

can we merge this already?

knottx · 2023-04-02T16:03:02Z

same issue on Xcode 14.3 with flutter

clindsay3 · 2023-04-17T23:57:41Z

Hey @dnkoutso what do you think about releasing 1.12.1 with what's in there now, to get this fix out in a public release? This seems like an urgent fix to a bug making CocoaPods essentially unusable, and Xcode 14.3 has been publicly available for a couple weeks now.

Sorry to bug you again, but it seems like you're the only active maintainer as far as I can tell?

dnkoutso · 2023-04-18T01:21:04Z

I would love to ship this but unfortunately I keep seeing various reports like this one and this one that perhaps its not the best fix?

I havent had time to look myself into the actual issue. I might end up shipping 1.12.1 by EOW unless any other maintainer does it before me.

clindsay3 · 2023-04-18T04:36:16Z

@dnkoutso Makes sense to be cautious! My sense though is that fixing this issue will unblock far more people than it will negatively impact.

And for what it's worth, neither of those reports you linked worry me, and I believe both should be resolved by the fix. I think what you're actually seeing is people having trouble applying the workaround.

I think part of what's going on is that the fix is in a script that generates a bunch of files. And the workaround I also gave was to just manually find/replace the line in question in the files that the script generated. So I think some people are trying the workaround, and then maybe not finding all the files, or reporting the name of the generated file that they needed to modify.

If there's one issue that I do think is worth keeping an eye on, it's probably this one. This person had a non-standard version of the readlink binary on his machine that didn't support the flag I added. For them, my fix will not work. However, it won't make things worse for them either.

Their suggested solution is to use greadlink, but since that would be adding a new dependency to cocoapods, I'm not sure how easy/desirable that would be. In the meantime though, I don't think it should prevent pushing out this change.

ehagerty · 2023-04-18T12:18:00Z

Hey @chrisvasselli, thanks for the link to my suggestion :-) I feel famous now!

@dnkoutso I feel comfortable that you can and should move ahead with the 'readlink' fix as is.

NB, it isn't that I have a non standard version of readlink. I'm fairly sure that /anyone/ who tries to use the /default/ version of readlink on an M1 mac will likely hit the -f error. I've seen this bug in places as disparate as builds of mongodb, fish shell etc. The reason people may /not/ hit the error is because the standard install of coreutils via brew creates a symbolic link from 'readlink' to the 'greadlink' binary. In other words, I'm hitting the error because I /am/ using the standard binary and everyone else is letting their system 'magically' use the 'non-standard' greadlink.

The other tickets are as @chrisvasselli suggests - a ton of noise because people crashed ahead with find and replace / HEAD branches etc instead of reading enough to understand what was going on. Anyone who us using brew/coreutils is covered - it is probably only antique C developers like me that have a system configured without the extra 'magic'.

I'm not a doctor, but I do play one on television - ymmv.

fivegreenapples · 2023-04-18T16:20:36Z

Hi @ehagerty re. your readlink/greadlink comments, I have done a little digging and I haven't found what you're suggesting. In fact rather the opposite:

On a friend's Mac Studio, M1 Max, macOS 13.3.1 (22E261), with no coreutils installed by brew, his readlink binary is very happy with readlink -f. Also the same on my wife's M1 Macbook Air (admittedly running macOS 12.something). fwiw on my Intel based iMac, also with no coreutils, my readlink is also fine.

So I kinda wonder what readlink is on your mac? Can you run which readlink to see where it is and confirm it is in the standard location, and also confirm it isn't symlinked to something unexpected. Also man readlink to see what that shows, and lastly double check that readlink -f errors.

Sorry that is a bunch of things to look at but I'd like to get to the bottom of it if possible.

For reference, this is output from my friend's M1 Mac:

~$ which readlink
/usr/bin/readlink
~$ ls -l /usr/bin/ | grep readlink
-rwxr-xr-x   2 root   wheel    135008  1 Apr 17:46 readlink

~$ man readlink
STAT(1)                     General Commands Manual                    STAT(1)

NAME
     stat, readlink – display file status

SYNOPSIS
     stat [-FLnq] [-f format | -l | -r | -s | -x] [-t timefmt] [file ...]
     readlink [-fn] [file ...]
etc...

clindsay3 · 2023-04-18T23:43:58Z

@fivegreenapples @ehagerty As far as I can tell I also don't have coreutils or greadlink installed:

brew list | grep coreutils
# no output

which readlink
/usr/bin/readlink

which greadlink
greadlink not found

And /usr/bin/readlink is not aliased.

I'm on an M1 MacBookPro running macOS 13.2.1.

HoustonDuane · 2023-04-19T08:17:17Z

Hi folks, I see that 1.12.1 has been released, and I've tried that with

sudo gem install cocoapods
sudo xcode-select -s /Applications/Xcode14_3.app/Contents/Developer
pod install

I make sure the Podfile.lock has updated the cocoapods version:

After hitting Clean Build Folder and rerunning the app, the problem persists.

Any idea?

fivegreenapples · 2023-04-19T08:41:36Z

@HoustonDuane I'm pretty sure your issue is the same as this one: #11808 (comment)

(To be clear I mean the thing mentioned in that comment, not the github issue it is part of)

HoustonDuane · 2023-04-19T08:54:52Z

@fivegreenapples Did you mean that upgrading to 1.12.1 does not solve the libarclite problem? Unfortunately I can't easily move up the deployment target to 11.0. Can anybody help?

fivegreenapples · 2023-04-19T09:17:42Z

@HoustonDuane

Did you mean that upgrading to 1.12.1 does not solve the libarclite problem?

No - 1.12.1 fixes only the 3 issues mentioned here: https://github.com/CocoaPods/CocoaPods/releases/tag/1.12.1
One of those is the fix in this pull request but that is not related to libarclite

Unfortunately I can't easily move up the deployment target to 11.0. Can anybody help?

From what I understand you just need to be above 8.0 (per this comment further down in that thread: #11808 (comment))

hth

HoustonDuane · 2023-04-19T10:13:52Z

@fivegreenapples A million thanks for your reply, I managed to solve the issue by adding the following to my Podfile:

post_install do |installer|
    installer.pods_project.targets.each do |target|
        # Fix libarclite_xxx.a file not found.
        target.build_configurations.each do |config|
            config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '9.0'
        end
    end
end

To anyone who's wondering, you only need to specify the deployment target greater than 8.0. I've not tried 8.0 itself, but 9.0 solves my problem (and I exactly need it to be 9.0).

Whew, it's been a journey! I've noticed Xcode 14.3 is blazing fast compared to 14.1, don't know what magic the developers from Apple has done.

Now I don't need to write redundant self. in closures in many cases! That's probably the biggest reason why I upgrade to Xcode 14.3. The new backDeployed attribute also interests me, but I don't know how big the scope would be of the features Apple fellas decide to back deploy to older iOS versions (from iOS 13.0 maybe?).

magsimillion · 2023-04-19T12:11:06Z

hello! first of all thank you so much for your fix; adding the -f flag has helped in fixing ONE problem. the thing is, another has arisen and I have the vague suspicion that it has something to do with the new Xcode update:

In signing & capabilities I continuously get these two errors:

Failed to register bundle identifier
The app identifier "{our identifier}" cannot be registered to your development team because it is not available. Change your bundle identifier to a unique string to try again.
No profiles for '{our identifier}' were found
Xcode couldn't find any iOS App Development provisioning profiles matching '{our identifier}'.

wouldn't these two errors imply that we a) already have an identifier with the same name but also b) it can't find the identifier?
now I've tried every fix I could find with a simple google search, but it still doesn't work. these fixes that I found were pretty old though and I've wondered, if this could be due to Xcode having similar path finding issues as described above in order to find our profile?

just as an aside: we have registered this identifier over on developer.apple.com and have successfully uploaded and released our app multiple times (only for beta testing now), but this has now stopped working since the update came out (and forced us to update in order to continue releasing the app).

cheers!

Looks like CocoaPods 1.12.1 is incompatible with < Xcode 14 due to CocoaPods/CocoaPods#11828 (see #123890 for context). Bump the minimum Xcode version allowed by tooling to 14, released September 2022. ``` [!] Xcode - develop for iOS and macOS (Xcode 13.4) â�� Flutter requires Xcode 14 or higher. Download the latest version or update via the Mac App Store. ``` Fixes #125286. Previous bump at #97746.

…1828

usmanabid94 · 2023-08-02T11:27:36Z

For the people facing error in Xcode after update to 14.3.

In your xcode, Go to PODS folder :
Target Support Files => Pods-{Your Project} => Pods-{Your Project}-frameworks

Change

source="$(readlink "${source}")"
this :

source="$(readlink -f "${source}")"

imilakovic · 2023-08-04T07:09:39Z

There's no need for workarounds any more, just upgrade CocoaPods to version 1.12.1

Please see this tag for more details:
https://github.com/CocoaPods/CocoaPods/releases/tag/1.12.1

Removes readlink patch CocoaPods/CocoaPods#11828

Ccalary · 2024-01-10T10:34:47Z

The same question，in Xcode15，I did this，solved it。Targets -> Build Setting -> Build Options -> User Script Sandboxing，set Yes To No。You can search "ENABLE_USER_SCRIPT_SANDBOXING"

clindsay3 mentioned this pull request Mar 23, 2023

Upgrade from Xcode 14.2 to 14.3 rsync: link_stat failed: No such file or directory (2) for pods that were working earlier. #11808

Closed

1 task done

olliwang mentioned this pull request Mar 27, 2023

Fixes the source path of frameworks #11833

Open

ehagerty reviewed Mar 29, 2023

View reviewed changes

clindsay3 changed the title ~~Pass the -f option when resolving the path to the symlinked source.~~ Xcode 14.3 fix: Pass the -f option when resolving the path to the symlinked source. Mar 30, 2023

chamodanethra reviewed Mar 31, 2023

View reviewed changes

dnkoutso added this to the 1.12.1 milestone Mar 31, 2023

Add an entry to changelog.

3c0eab0

clindsay3 mentioned this pull request Apr 1, 2023

Update spec for PR 11828 CocoaPods/cocoapods-integration-specs#341

Merged

fleoparra mentioned this pull request Apr 1, 2023

Linker command failed with exit code 1 (use -v to see invocation) flutter/flutter#123903

Closed

Update integrations spec

a48c60b

alkanyunus approved these changes Apr 1, 2023

View reviewed changes

dnkoutso mentioned this pull request Apr 18, 2023

Rsync Error On Xcode 14.3 and Cocoapods 1.12.0 #11868

Closed

SmallYuuu mentioned this pull request Apr 26, 2023

Crash on iOS 13.7 finamp-app/finamp#437

Closed

jmagman mentioned this pull request Apr 27, 2023

Increase Xcode minimum version to 14 flutter/flutter#125639

Merged

8 tasks done

EkkoG added a commit to EkkoG/CocoaPods that referenced this pull request May 4, 2023

Fixed build failed when use Xcode 13, issue introduced by CocoaPods#1…

bb8bcc0

…1828

winstondu mentioned this pull request May 25, 2023

PSA: Note that injected symlink code interferes with Cocoapods 1.12.1 leavez/cocoapods-binary#167

Open

jbtech123 mentioned this pull request Jul 5, 2023

flutter build ipa --profile command don't work flutter/flutter#129982

Closed

dnkoutso mentioned this pull request Aug 17, 2023

Xcode 15 beta 6 pod repo push fails with deployment target too low #12033

Open

pash3r added a commit to youla-dev/cocoapods-binary that referenced this pull request Sep 25, 2023

Fix for Xcode 14.3+ and Cocoapods 1.12.1+

97cdb08

Removes readlink patch CocoaPods/CocoaPods#11828

closure11 mentioned this pull request Dec 13, 2023

[CP] Embed Pods Frameworks fails when Archiving grab/cocoapods-binary-cache#49

Closed

3 tasks done

shankari mentioned this pull request May 5, 2024

XCode and osx-build-ios CI need updating e-mission/e-mission-docs#1060

Closed

Conversation

clindsay3 commented Mar 23, 2023

Uh oh!

ehagerty left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gali8 commented Mar 30, 2023

Uh oh!

holyavkin commented Mar 30, 2023

Uh oh!

clindsay3 commented Mar 30, 2023

Uh oh!

clindsay3 commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ehagerty commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaybhum Apr 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivegreenapples commented Mar 31, 2023

Uh oh!

dnkoutso commented Mar 31, 2023

Uh oh!

clindsay3 commented Apr 1, 2023

Uh oh!

clindsay3 commented Apr 1, 2023

Uh oh!

geminiwen commented Apr 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maccman commented Apr 1, 2023

Uh oh!

concernedrat commented Apr 1, 2023

Uh oh!

arnab commented Apr 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnkoutso commented Apr 1, 2023

Uh oh!

samueldeschamps commented Apr 1, 2023

Uh oh!

clindsay3 commented Apr 1, 2023

Uh oh!

serbixote commented Apr 2, 2023

Uh oh!

knottx commented Apr 2, 2023

Uh oh!

clindsay3 commented Apr 17, 2023

Uh oh!

dnkoutso commented Apr 18, 2023

Uh oh!

clindsay3 commented Apr 18, 2023

Uh oh!

ehagerty commented Apr 18, 2023

Uh oh!

fivegreenapples commented Apr 18, 2023

Uh oh!

clindsay3 commented Apr 18, 2023

ehagerty left a comment •

edited

Loading

clindsay3 commented Mar 30, 2023 •

edited

Loading

ehagerty commented Mar 31, 2023 •

edited

Loading

jaybhum Apr 1, 2023 •

edited

Loading

geminiwen commented Apr 1, 2023 •

edited

Loading

arnab commented Apr 1, 2023 •

edited

Loading

HoustonDuane commented Apr 19, 2023 •

edited

Loading

fivegreenapples commented Apr 19, 2023 •

edited

Loading

HoustonDuane commented Apr 19, 2023 •

edited

Loading

fivegreenapples commented Apr 19, 2023 •

edited

Loading

HoustonDuane commented Apr 19, 2023 •

edited

Loading