Repository navigation
Fix linting when armv7 is included but i386 isn't - #8159
Merged
Merged
Conversation
Contributor
|
Super agree validator is a tough class to write tests for...there are some though that print out the command so I think you might be able to copy-paste an existing one and verify the parameters passed are correct. |
Member
Author
|
Yeah, I found a test that is close at https://github.com/CocoaPods/CocoaPods/blob/master/spec/unit/validator_spec.rb#L622, but I couldn't figure out how to set or mock the architectures, like |
dnkoutso
reviewed
Oct 4, 2018
| when :ios | ||
| command += %w(CODE_SIGN_IDENTITY=- -sdk iphonesimulator) | ||
| command += Fourflusher::SimControl.new.destination(:oldest, 'iOS', deployment_target) | ||
| xcconfig = consumer.spec.attributes_hash['pod_target_xcconfig'] |
Contributor
There was a problem hiding this comment.
You want to use consumer.pod_target_xcconfig here as it will take care of merging values etc. See https://github.com/CocoaPods/Core/blob/master/lib/cocoapods-core/specification/consumer.rb#L99-L102
Contributor
|
@paulb777 needs a rebase and it should be OK |
Member
Author
|
Done. Thanks @dnkoutso! |
dnkoutso
approved these changes
Oct 5, 2018
segiddins
approved these changes
Oct 10, 2018
1 task done
12 of 13 tasks
mklim
pushed a commit
to flutter-team-archive/plugins
that referenced
this pull request
Sep 30, 2019
- Limit the supported podspec platform to iOS so tests don't run (and fail) for macOS. - Define the module by setting `DEFINES_MODULE` in the podspec. See [CocoaPod modular headers docs](http://blog.cocoapods.org/CocoaPods-1.5.0/). - Explicitly set `VALID_ARCHS` to architectures included in the Flutter universal binary. This is the CocoaPods-suggested workaround to prevent tests from running on the i386 simulator. See CocoaPods/CocoaPods#8159.
This was referenced Sep 30, 2019
Vallasc
pushed a commit
to Vallasc/camera_plugin
that referenced
this pull request
Nov 9, 2019
- Limit the supported podspec platform to iOS so tests don't run (and fail) for macOS. - Define the module by setting `DEFINES_MODULE` in the podspec. See [CocoaPod modular headers docs](http://blog.cocoapods.org/CocoaPods-1.5.0/). - Explicitly set `VALID_ARCHS` to architectures included in the Flutter universal binary. This is the CocoaPods-suggested workaround to prevent tests from running on the i386 simulator. See CocoaPods/CocoaPods#8159.
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
- Limit the supported podspec platform to iOS so tests don't run (and fail) for macOS. - Define the module by setting `DEFINES_MODULE` in the podspec. See [CocoaPod modular headers docs](http://blog.cocoapods.org/CocoaPods-1.5.0/). - Explicitly set `VALID_ARCHS` to architectures included in the Flutter universal binary. This is the CocoaPods-suggested workaround to prevent tests from running on the i386 simulator. See CocoaPods/CocoaPods#8159.
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
- Limit the supported podspec platform to iOS so tests don't run (and fail) for macOS. - Define the module by setting `DEFINES_MODULE` in the podspec. See [CocoaPod modular headers docs](http://blog.cocoapods.org/CocoaPods-1.5.0/). - Explicitly set `VALID_ARCHS` to architectures included in the Flutter universal binary. This is the CocoaPods-suggested workaround to prevent tests from running on the i386 simulator. See CocoaPods/CocoaPods#8159.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8129
I verified the bug report is fixed by this. If unit tests are needed, I'd appreciate tips on the right approach.