Skip to content

Top frame package sources should not be deemphasized if breaking on breakpoints #1502

Closed
Closed
Top frame package sources should not be deemphasized if breaking on breakpoints#1502
Labels
in debuggingRelates to the debug adapter or process of running debug sessionsis bug
Milestone
v2.25.0

Description

@DanTup
DanTup
opened on Mar 4, 2019

Split from #1497. We should not set deemphasize on external source if the user had specifically put a breakpoint in there (though we probably do still want to collapse the SDK stack frames, etc., so may wish to only remove it from the top frame).

Activity

  1. DanTup
    added
    is bug
    in debuggingRelates to the debug adapter or process of running debug sessions
    on Mar 4, 2019
  2. DanTup
    added this to the v2.25.0 milestone on Mar 4, 2019
  3. DanTup
    changed the title [-]Package sources should not be deemphasized if breaking on breakpoints[/-] [+]Top frame package sources should not be deemphasized if breaking on breakpoints[/+] on Mar 4, 2019
  4. DanTup
    added a commit that references this issue on Mar 4, 2019

    Add failing test for #1502

    2356808
  5. DanTup
    closed this as completedin 2140798on Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsis bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions