Skip to content

stdio.dart is not coloured correctly #1635

Closed

Description

@DanTup

Screenshot 2019-04-22 at 11 55 34 am

Activity

  1. added this to the v2.26.0 milestone on Apr 22, 2019
  2. DanTup commented on Apr 24, 2019

    @DanTup
    MemberAuthor

    This is caused by the indenting of /** multi-line */ blocks, it was matching the 4-space-indent and being considered code. This included the last line */ so it didn't "exit" the comment properly.

    For testing, I duplicated everything in the comments file and put it inside a class so it was indented enough. After the fix, the only change was the bit we wanted:

    Screenshot 2019-04-24 at 11 17 47 am

    @devoncarew FYI. It's possible I introduced this with one of the earlier changes, so if you don't have them you might not need this. Best way is to type stdio and then Go-to-Def on it, and see whether most of the file is green/comment.

    I've scanned through a few of the large Flutter files and made sure there are no other obvious instances of anything like this, nor any files that are comments till the end.

  3. added a commit that references this issue on Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis bug

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions