Skip to content

Flutter UI Guides preview feedback #1731

Closed

Description

@DanTup

For info on the Flutter UI Guides preview, see the v3.31 release notes. This thread is for collecting feedback on the guides (including the customTracking setting).

Activity

  1. added this to the On Deck milestone on May 21, 2019
  2. digitalhurricane-io commented on Jun 1, 2019

    @digitalhurricane-io

    I have both dart.previewFlutterUiGuides and dart.previewFlutterUiGuidesCustomTracking enabled.

    I've restarted vscode.

    When I write new code, the guidelines appear.

    But they don't appear on code that I've already written.

    Edit: Seems to not appear only on some code I've already written.

    Is that expected behavior?

  3. DanTup commented on Jun 1, 2019

    @DanTup
    MemberAuthor

    @digitalhurricane-io it's not expected behaviour :( Do you have any syntax errors in the file/code that isn't working? Would you mind opening a new issue specifically for this, and include screenshots of the code that's not working? Thanks!

  4. digitalhurricane-io commented on Jun 1, 2019

    @digitalhurricane-io

    I'm nesting widgets inside a ternary operator on the offending code. Perhaps this is why?

    Edit: I've opened an issue with a screenshot of the code here #1771

  5. windwp commented on Jun 3, 2019

    @windwp

    UI guides do not work inside the builder.

  6. marcoms commented on Jun 11, 2019

    @marcoms

    Guide formatting breaks when using tabs for indentation

  7. DanTup commented on Jun 12, 2019

    @DanTup
    MemberAuthor

    @marcoms good catch - I opened #1791 specifically for that and will fix for vNext.

  8. jckpn commented on Jun 28, 2019

    @jckpn

    Only works in some files for me... not sure why or what I'm doing wrong.

    Here it works great:
    image

    Here it doesn't seem to work (at least not how I would expect):

    image

    (Both are files I wrote before enabling the UI guides)

    This is such a great idea in theory though, will make writing code in Flutter so much nicer.

  9. DanTup commented on Jul 8, 2019

    @DanTup
    MemberAuthor

    @jckpn the second screenshot uses builders, which didn't support these. I believe that's been improved in a later SDK, but hasn't made the Flutter stable channel yet. Hopefully it'll just start working when it does :-)

  10. a-eid commented on Dec 25, 2019

    @a-eid

    not sure why it looks like that for me..

    Screen Shot 2019-12-25 at 13 56 09

  11. a-eid commented on Dec 25, 2019

    @a-eid

    could be the custom line height I think..

  12. DanTup commented on Jan 2, 2020

    @DanTup
    MemberAuthor

    @a-eid what is your line-height set to? Custom line heights will cause gaps (see #1902) but it shouldn't have such large spaces unless you've set your line height really high.

  13. emme1444 commented on Feb 8, 2020

    @emme1444

    Italic multiline comments causes the guidelines within the comment to also tilt.
    See screenshot:
    Screenshot 2020-02-08 at 15 59 42

  14. DanTup commented on Feb 13, 2020

    @DanTup
    MemberAuthor

    @emme1444 looks like that's been filed at #2239 - thanks!

  15. DanTup commented on Oct 27, 2020

    @DanTup
    MemberAuthor

    Thanks for all the feedback. I don't think there's much more to collect from this issue so I'll close it. The UI guides feature remains behind a preview flag because it's method of rendering is not too reliable but there are currently no other available APIs.

    If VS Code gets a better API for this in the future (microsoft/vscode#73780), we can move them over and hopefully have something good enough to ship on-by-default.

  16. removed this from the On Deck milestone on Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions