How to change named parameters color in color theme? #1900

Activity

1. DanTup commented on Aug 1, 2019

   

   DanTup

   on Aug 1, 2019

   Member

   More actions

   I don't think it's currently possible - though is your screenshot from VS Code or IntelliJ? If VS Code, which theme is it that shows them in yellow?
2. JCKodel commented on Aug 1, 2019

   

   JCKodel

   on Aug 1, 2019 via email

   Author

   More actions

   The screenshot is VSCode (I've painted yellow using an image editor, just for illustration purposes).

   …

   On Thu, Aug 1, 2019 at 2:31 PM Danny Tuppeny ***@***.***> wrote: I don't think it's currently possible - though is your screenshot from VS Code or IntelliJ? If VS Code, which theme is it that shows them in yellow? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1900?email_source=notifications&email_token=AAC4TSYIDVGHZ66VWCQJPELQCMMYBA5CNFSM4IIRC6RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3LKUCQ#issuecomment-517384714>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC4TS7S7DIIJYMH4S42UT3QCMMYBANCNFSM4IIRC6RA> .
3. DanTup commented on Aug 5, 2019

   

   DanTup

   on Aug 5, 2019

   Member

   More actions

   Oh, I see :-)

   In theory, I think it shouldn't be difficult to assign these a different scope so they could be coloured differently. In practice, every time I change the grammar file I break stuff 😄 I'll see what I can do though.

   👍React with 👍1Reacted by J.C.Ködel
4. DanTup

   added this to the v3.4.0 milestone on Aug 5, 2019
5. DanTup

   added

   in editorRelates to code editing or language featuresRelates to code editing or language features

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Aug 5, 2019
6. DanTup

   modified the milestones: v3.4.0, v3.5.0 on Aug 26, 2019
7. DanTup

   modified the milestones: v3.5.0, v3.6.0 on Oct 1, 2019
8. DanTup

   modified the milestones: v3.6.0, v3.7.0 on Oct 28, 2019
9. DanTup commented on Nov 20, 2019

   

   DanTup

   on Nov 20, 2019

   Member

   More actions

   Upon reviewing the syntax file, I don't think this would be easy. I think there may be upcoming changes to how syntax highlighting works in VS Code (switching to another format from textmate grammars) so I think it would be better to handle this then (since the new format may be better, and may be more easily testable!).
10. DanTup

    modified the milestones: v3.7.0, On Deck on Nov 20, 2019
11. SoKamil commented on May 22, 2020

    

    SoKamil

    on May 22, 2020

    Last edited by SoKamil

    More actions

    microsoft/vscode#95958
    They did something and also they introduced semantic highlighting for TS and JS, and they have announced it for Java and C++
12. DanTup commented on May 25, 2020

    

    DanTup

    on May 25, 2020

    Member

    More actions

    I do plan to support semantic highlighting - but it will be using LSP (which we're migrating to, but it doesn't have semantic highlighting support yet - the API is still only proposed).
13. DanTup

    added

    in lsp/analysis serverSomething to be fixed in the Dart analysis serverSomething to be fixed in the Dart analysis server

    on Jun 22, 2020
14. DanTup

    modified the milestones: On Deck, v3.18.0, v3.19.0 on Dec 10, 2020
15. DanTup commented on Jan 19, 2021

    

    DanTup

    on Jan 19, 2021

    Member

    More actions

    Once https://dart-review.googlesource.com/c/sdk/+/179769 lands (and you're on an SDK that uses it and have the LSP Preview enabled), you'll be able to set the colours of parameter names at call sites with the following settings:

    	"editor.semanticTokenColorCustomizations": {
    		"rules": {
    			"parameter.label": "#990",
    		},
    	},

    
16. DanTup

    closed this as completedon Jan 19, 2021