Skip to content

Consider showing Emulator names against running devices #1983

Closed

Description

@DanTup

flutter devices gets device names from the device, which results in Emulators not showing the same name as in Android Studio of flutter emulators:

flutter/flutter#11850

Recently we improved flutter emulators to show matching names to Android Studio and surfaced these better in VS Code. However there's still confusion that you launch an emulator and then its name becomes "Android SDK built for x86".

Since as part of the Emulator names change, we made VS Code figured out which emulators match which devices (so we can hide Emulators if they're already running as devices) that means we also know the "Emulator Name" for running devices that are Emulators. Instead of just hiding the emulator, we could fold its name into the device, resulting in showing the "good" name for the running devices.

We could potentially do this on the Flutter side, but it would mean making flutter devices slower (it'd need to connect to each device to get the AVD name, then enumerate emulators and read their ini files).

  • Currently only shows in picker, but should be consistent (status bar etc.)

Activity

  1. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    in flutterRelates to running Flutter apps
    on Sep 11, 2019
  2. added this to the v3.5.0 milestone on Sep 11, 2019
  3. DanTup commented on Sep 11, 2019

    @DanTup
    MemberAuthor

    This seems to work - here's the offline emulators:

    Screenshot 2019-09-11 at 11 29 29 am

    And after launching two of them, they now show with the same emulator names:

    Screenshot 2019-09-11 at 11 28 46 am

    However this is only the picker, the status bar and other places still use the old one - so we need to find a way to tie these up earlier (or, make the change in Flutter).

    I'm thinking again about handling in Flutter though; added a comment here -> flutter/flutter#11850 (comment)

  4. modified the milestones: v3.5.0, On Deck on Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in flutterRelates to running Flutter appsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions