Unable to debug files in test that are not tests #2034

Activity

1. DanTup commented on Oct 7, 2019

   

   DanTup

   on Oct 7, 2019

   Member

   More actions

   This is slightly related to #2021 (and #1165). The current behaviour is that anything that ends with _test.dart or inside the top-level test directory is considered a test. The request in #2021 is to stop assuming everything ending with _test.dart, and this one is to not assume anything in test - though I'm not sure we can do both (we'd end up categorising nothing as tests).

   Poking around inside the source to guess if they're tests seems more error prone (it's possible you don't directly use package:test in a test script, since you might have wrappers for groups/tests, like Flutter does). Maybe we could require being inside a test folder and end with _test.dart?
2. DanTup

   added this to the v3.6.0 milestone on Oct 7, 2019
3. DanTup

   added

   in debuggingRelates to the debug adapter or process of running debug sessionsRelates to the debug adapter or process of running debug sessions

   in testingRelates to test execution of Dart/Flutter tests for end usersRelates to test execution of Dart/Flutter tests for end users

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Oct 7, 2019
4. bergwerf commented on Oct 7, 2019

   

   bergwerf

   on Oct 7, 2019 via email

   Author

   More actions

   I suppose that's what pub run test does so that would make sense (in test and _test.dart). Isn't is possible to somehow exit if pub test can't run any tests (instead of hanging, with a notification "can't find tests or something") or fallback to normal debugging if pub test doest find any tests? At least now it's not clear to the uses why it's hanging and how to solve it (feels like a bug in the debugger).

   …

   On Mon, Oct 7, 2019, 10:08 Danny Tuppeny ***@***.***> wrote: This is slightly related to #2021 <#2021> (and #1165 <#1165>). The current behaviour is that anything that ends with _test.dart or inside the top-level test directory is considered a test. The request in #2021 <#2021> is to stop assuming everything ending with _test.dart, and this one is to not assume anything in test - though I'm not sure we can do both (we'd end up categorising nothing as tests). Poking around inside the source to guess if they're tests seems more error prone (it's possible you don't directly use package:test in a test script, since you might have wrappers for groups/tests, like Flutter does). Maybe we could require being inside a test folder *and* end with _test.dart? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2034?email_source=notifications&email_token=ABCATVK27HJTZDIWRCTRQHTQNLVAVA5CNFSM4I5537PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPL7MQ#issuecomment-538886066>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCATVLML7OM4Q4OUK5AECDQNLVAVANCNFSM4I5537PA> .
5. DanTup commented on Oct 7, 2019

   

   DanTup

   on Oct 7, 2019

   Member

   More actions

   Yeah, it definitely shouldn't hang - it should fail and be obvious what's up. I'll take a look at that before I change the rules too.
6. DanTup commented on Oct 7, 2019

   

   DanTup

   on Oct 7, 2019

   Member

   More actions

   @bergwerf I can't reproduce a hang, it seems to run my non-test script fine:

   

   Are you doing anything different? Could you capture a log using Dart: Capture Logs (leave everything ticked except Analysis Server).

   Thanks!
7. DanTup

   closed this as completedin 4983d93on Oct 7, 2019