Some unicode characters are replaced with bad characters when formatting document #2140

Activity

10. DanTup

    added

    in editorRelates to code editing or language featuresRelates to code editing or language features

    is bug

    on Dec 3, 2019
11. DanTup

    added this to the On Deck milestone on Dec 3, 2019
12. DanTup

    added

    awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

    on Dec 3, 2019
13. DanTup commented on Dec 3, 2019

    

    DanTup

    on Dec 3, 2019

    Member

    More actions

    @ashamp please comment here next time you see this with the info above and a log. Thanks!
14. DanTup

    changed the title [-]VSCode may cause bad char after format code![/-] [+]Some unicode characters are replaced with bad characters when formatting document[/+] on Dec 3, 2019
15. 9 remaining items

    Load more

16. DanTup commented on Feb 24, 2020

    

    DanTup

    on Feb 24, 2020

    Member

    More actions

    This appears to have broken some things, so hold off with the test build for now - I'm investigating and will upload a new build when resolved!
17. DanTup commented on Feb 24, 2020

    

    DanTup

    on Feb 24, 2020

    Member

    More actions

    Ok, new test build at https://github.com/Dart-Code/Dart-Code/releases/tag/v3.9.0-alpha.2 - see instructions above for installing.
18. DanTup

    added 3 commits that reference this issue on Feb 24, 2020

    Add a (skipped) test for #2140

    6dd51d7

    Keep stdout buffers to concat instead of converting to strings

    ...

    1d31cc4

    Uskip test for #2140

    d0c40e2
19. DanTup commented on Feb 24, 2020

    

    DanTup

    on Feb 24, 2020

    Member

    More actions

    I was able to make a reliable test for this (6dd51d7) for this, and it passes with the fix, so I'm confident this was the issue. I'll land the change then the PR goes green.

    You can use the test build linked above in the meantime. Thanks for the help tracking it down!
20. DanTup

    closed this as completedin #2270on Feb 25, 2020
21. DanTup

    added 2 commits that reference this issue on Feb 25, 2020

    Keep stdout buffers to concat instead of converting to strings

    ...

    This issue will close once commit 6463d46 is merged into the 'master' branch.

    6463d46

    Uskip test for #2140

    This issue will close once commit 4b88fd2 is merged into the 'master' branch.

    4b88fd2
22. DanTup

    modified the milestones: On Deck, v3.9.0 on Feb 25, 2020
23. mstepanov214 commented on Feb 26, 2020

    

    mstepanov214

    on Feb 26, 2020

    More actions

    @DanTup Really, now I can't reproduce the problem in the old way. Thank you for your help!
24. DanTup commented on Feb 26, 2020

    

    DanTup

    on Feb 26, 2020

    Member

    More actions

    @mstepanov214 do you mean you can't reproduce with the new build, or the live stable build? It shouldn't reproduce in the test build, but in the live stable build you should be able to trigger it. I did it with a file with 130 lines of emoji:

    // 🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈
    // 🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈
    // 🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈
    // 🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈
    // 🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈🙈
    // x 130!
    

    Then just insert some newlines somewhere and run Format Document and usually you'll get some corruption.
25. mstepanov214 commented on Feb 26, 2020

    

    mstepanov214

    on Feb 26, 2020

    More actions

    @DanTup I meant the new build of course
26. DanTup commented on Feb 29, 2020

    

    DanTup

    on Feb 29, 2020

    Member

    More actions

    Got it - thanks for confirming! :-)