Skip to content

Bring back larger build/hot reload notifications #2597

Closed

Description

hotreloading process is not showing in the notification bar,I did not updated the flutter sdk,but a few hours before the issue ive seen a notification about "Dart sdk has been updated".
completely uninstalled and recreated a new project but the issue remains same,Only when the hotlreload is finished its logged in console "Reloaded 0 of 495 libraries in 167ms."

Expected Progress indication for hotreload is..
85929623-1ac64380-b8d4-11ea-8a3f-2db99d40f4b0

Activity

  1. added this to the v3.12.1 milestone on Jun 30, 2020
  2. added
    in debuggingRelates to the debug adapter or process of running debug sessions
    in flutterRelates to running Flutter apps
    on Jun 30, 2020
  3. DanTup commented on Jun 30, 2020

    @DanTup
    Member

    Thanks for the report! There was a bug here, but also we adopted a new API in VS Code which unfortunately doesn't show progress notifications for 500ms, so very short progress notifications would not show at all.

    For now, I've reverted to handling the progress notifications ourselves. I'll push out a minor update shortly.

    Note - even with this change, the status will now show only in the status bar by default (not in a large notification as in your screenshot). This was requested by the VS Code team.

  4. DanTup commented on Jul 1, 2020

    @DanTup
    Member

    @rajeshjeshar the new status notification should appear over on the left, and it should show "Hot reloading.." with a spinner. Once it completes, it should show Hot reload complete!" for a further 150ms.

    The goal is still to move to the debug-adapter-protocol status message once it's been improved, which gives us no ability to show a larger progress notification. We can do this with custom messages, but I'd really like to stick to the DAP spec so that the debugger is more portable.

    Therefore, if the current notifications are not obvious enough, I think it would be better to improve in DAP/VS Code. I'll add a note on microsoft/vscode#101405 about this.

  5. modified the milestones: v3.12.1, Backlog on Jul 6, 2020
  6. changed the title [-]Hot reloading is not indicated[/-] [+]Bring back larger build/hot reload notifications[/+] on Jul 6, 2020
  7. DanTup commented on Jul 6, 2020

    @DanTup
    Member

    I've opened microsoft/vscode#101791 specifically for VS Code to consider support this with DAP messages. Please add a 👍 to microsoft/vscode#101791!

  8. reopened this on Jul 6, 2020
  9. modified the milestones: Backlog, v3.16.0 on Oct 8, 2020
  10. added
    is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.
    and removed on Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in debuggingRelates to the debug adapter or process of running debug sessionsin flutterRelates to running Flutter appsis enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions