Repository navigation
Icon previews in hovers are broken for icons that start with numbers #3843
Description
Describe the bug
I was working with icons and found that:
- Few icons are not previewed while hovering but are previewed near line numbers (checked the location where the icons are stored and it seems that there might be a mismatch in the mapping of names - screenshots attached)
- Few icons are not previewed while hovering nor near the line numbers (checked the location where the icons are stored and it seems that the icons are not there)
To Reproduce
Steps to reproduce the behavior:
- Please try to preview the icons in VSCode
Expected behavior
The icons must be previewed while hovering, near the line numbers.
Screenshots
Versions (please complete the following information):
- VS Code Insiders version:
Version: 1.65.0-insider (user setup)
Commit: 3112460dc48ce7e557ea9feeaae04b912164b48b
Date: 2022-02-24T05:15:20.989Z
Electron: 16.0.9
Chromium: 96.0.4664.174
Node.js: 16.9.1
V8: 9.6.180.23-electron.0
OS: Windows_NT x64 10.0.19042 - Dart extension version:
Dart v3.35.20220222 Pre-Release - Flutter extension version:
Flutter v3.35.20220201 Pre-Release - Dart/Flutter SDK version:
C:\Users\NEW>flutter --version
Flutter 2.10.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 097d3313d8 (6 days ago) • 2022-02-18 19:33:08 -0600
Engine • revision a83ed0e5e3
Tools • Dart 2.16.1 • DevTools 2.9.2
C:\Users\NEW>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 2.10.2, on Microsoft Windows [Version 10.0.19042.1526], locale en-IN)
[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
[√] Chrome - develop for the web
[X] Visual Studio - develop for Windows
X Visual Studio not installed; this is necessary for Windows development.
Download at https://visualstudio.microsoft.com/downloads/.
Please install the "Desktop development with C++" workload, including all of its default components
[√] Android Studio (version 2020.3)
[√] Connected device (3 available)
[√] HTTP Host Availability
! Doctor found issues in 1 category.
C:\Users\NEW>dart --version
Dart SDK version: 2.16.1 (stable) (Tue Feb 8 12:02:33 2022 +0100) on "windows_x64"
I am happy to contribute.
Please let me know if any further information is required.
Thanks for this wonderful plugin !!
Activity
[-]Icon failed to load in vscode[/-][+]Icon previews in hovers are broken for icons that start with numbers[/+]DanTup commentedon Feb 28, 2022
Thanks, glad you like it!
Thanks for the offer, although this turned out to be a little fiddly. There are actually two issues:
DanTup commentedon Feb 28, 2022
DanTup commentedon Feb 28, 2022
Nope, that one was just me testing it badly. Looks good now:
Thanks!
Fix Flutter icon previews for icons that start with numerics
guidezpl commentedon Mar 12, 2022
This won't work for a small set of icons which use a different for of rewrites (e.g. try_sms_star). I recommend using https://github.com/flutter/flutter/blob/504e66920005937b6ffbc3ccd6b59d594b0e98c4/dev/tools/update_icons.dart#L500, which handles both cases
DanTup commentedon Apr 6, 2022
Missed this before - I've opened #3913 about that. I can copy the exceptions from there, although they'll need to be maintained. I wonder if there's a better way that won't need so much maintenance (or if we could at least push some of this logic to https://github.com/flutter/tools_metadata.
Update to latest Flutter icons