Repository navigation
Re-generate from latest beta branch - #30
Conversation
Sure - looking now. |
devoncarew
left a comment
There was a problem hiding this comment.
That is a lot of new files!
I wonder if we should have a CI which runs ~weekly, and fails if the frameworkVersion is older that the current stable? We're reving from 2.2.0 ==> 2.11.0-0.1.pre.
Yup. The more this grows, the more I feel like shipping them all inside the extension isn't the right call. I think IntelliJ is extracting them from the icon now, but that doesn't work very well for VS Code. It'd be god to get this in the server (similar to colours), but it would require Flutter having (or generating) them on-disk in the package (which I suspect is also not ideal).
Yeah, that would catch some issues like Dart-Code/Dart-Code#3843 (although, that one has added complexity that the rewriting of doc comments don't have the same names as the files on disk). I can have a look at setting that up on GH Actions (if that's suitable) assuming the repo allows. |
|
Apparently the PR check bot is running the entire script too... Perhaps if it's set up to run weekly it could just open a PR 😄 |
|
Hmm, it looks like the script is failing w/ an NPE here: https://github.com/flutter/tools_metadata/blob/master/tool/catalog/generate_widget_catalog.dart#L144, when trying to validate the generation? |
|
Odd, it completed when I ran it locally - I'll take a look soon. This isn't blocking for VS Code (I don't use this repo directly, I copy the folder, so I just copied it from this branch in the last release), but I presume IntelliJ will also want to update to get the new icons. |
|
I think maybe I only did the icons when I ran locally, so didn't hit the NPE. I've opened #31 with a fix for that (+ package upgrades and null-safe changes) and will rebase this and add another commit with the non-icon changes I missed after that's done. |
|
@devoncarew this PR is now green, but it includes some additional changes (upgrading deps to get latest analyzer package, which also means null-safe changes). To make it easier to review, I opened a PR with everything except the image file changes. We should just merge this PR once you're happy with it all though and close that one. The changes include:
I reviewed some of the image changes more closely, and it looks like there were some alignment issues in the previous generation, as running now seems to align the icons better within the box, for example: I'm not sure why they were misaligned before, but they at least some correct now. |

This is the result of running
flutter pub run grinder generateagainst the current Flutterbetabranch.I committed in three commits to make it easier to review:
@devoncarew are you a good person to review/merge this?