Include device name in run process / default launch.json #4491

Activity

1. guidezpl

   added

   is enhancementAn enhancement or improvement that should be listed in release notes but is not a bug fix.An enhancement or improvement that should be listed in release notes but is not a bug fix.

   on Apr 13, 2023
2. DanTup commented on Apr 13, 2023

   

   DanTup

   on Apr 13, 2023

   Last edited by DanTup

   Member

   More actions

   in this case, using the default generated launch.json

   Can you confirm what you mean by "generated" here? There's no launch.json created by default (you can run apps without one), but there are a few ways you can trigger them to be created (or be populated). Device names should be included automatically in at least some of those places (eg. #3937).
3. DanTup

   added

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on Apr 13, 2023
4. guidezpl commented on Apr 13, 2023

   

   guidezpl

   on Apr 13, 2023

   ContributorAuthor

   More actions

   

   From the Run and Debug panel, if you click "create a launch.json file" and then "Dart & Flutter" you get a generic file that makes running an app on multiple devices more cumbersome

   {
       // Use IntelliSense to learn about possible attributes.
       // Hover to view descriptions of existing attributes.
       // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
       "version": "0.2.0",
       "configurations": [
           {
               "name": "flutter_repro_app",
               "request": "launch",
               "type": "dart"
           },
           {
               "name": "flutter_repro_app (profile mode)",
               "request": "launch",
               "type": "dart",
               "flutterMode": "profile"
           },
           {
               "name": "flutter_repro_app (release mode)",
               "request": "launch",
               "type": "dart",
               "flutterMode": "release"
           }
       ]
   }
   
5. DanTup commented on Apr 17, 2023

   

   DanTup

   on Apr 17, 2023

   Member

   More actions

   It used to be the case that we'd only automatically add the device name into the session name if it didn't already have one (eg. if you deleted launch.json and just pressed F5).

   I've changed this now so as long as your launch config doesn't have an explicit deviceId, we'll always add the device name onto the end. There's no change to the launch.json, since we'll append it to whatever is there.
6. DanTup

   added this to the v3.64.0 milestone on Apr 17, 2023
7. DanTup

   added

   in flutterRelates to running Flutter appsRelates to running Flutter apps

   in debuggingRelates to the debug adapter or process of running debug sessionsRelates to the debug adapter or process of running debug sessions

   and removed

   awaiting infoRequires more information from the customer to progressRequires more information from the customer to progress

   on Apr 17, 2023
8. DanTup commented on Apr 17, 2023

   

   DanTup

   on Apr 17, 2023

   Member

   More actions

   Fixed by ae5b6ed.
9. DanTup

   closed this as completedon Apr 17, 2023
10. guidezpl commented on Apr 18, 2023

    

    guidezpl

    on Apr 18, 2023

    ContributorAuthor

    More actions

    Sweet, thanks!