Skip to content

main method CodeLens provider can take 5s, delaying interaction with other CodeLenses #5047

Closed
Closed
main method CodeLens provider can take 5s, delaying interaction with other CodeLenses#5047
Labels
in editorRelates to code editing or language featuresis bugrelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
Milestone
v3.86.0

Description

@DanTup
DanTup
opened on Mar 27, 2024

When testing Augmentation/Augmented CodeLens, I frequently see 5s delays in being able to interact with them. This appears to be caused by the main CodeLens provider taking a long time.

This happens because of the wait here:

Dart-Code/src/extension/code_lens/main_code_lens_provider.ts

Line 26 in 9a21d26

const outline = await this.analyzer.fileTracker.waitForOutlineWithLength(document.uri, expectedLength, token);

We should remove this wait and instead return no items if the outline isn't ready, and schedule a (one-time) refresh of CodeLens once the outline updates.

Activity

  1. DanTup
    added
    is bug
    in editorRelates to code editing or language features
    on Mar 27, 2024
  2. DanTup
    added this to the v3.86.0 milestone on Mar 27, 2024

  3. DanTup commented on Mar 27, 2024

    @DanTup
    DanTup
    on Mar 27, 2024
    MemberAuthor

    This is basically because of #5048. The problem wasn't that it was sometimes slow, it just never arrived for newly opened files.

  4. DanTup
    closed this as completedon Mar 27, 2024
  5. DanTup
    added
    relies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available
    on Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    in editorRelates to code editing or language featuresis bugrelies on sdk changesSomething that requires changes in the Dart/Flutter SDK to ship before it will become available

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions