Repository navigation
dart/textDocument/publishOutline (and other notifications) are not sent for newly opened files #5048
Description
While investigating #5047, I opened my augmentation testing project. It had main_augmentation.dart already open and in the logs I see a dart/textDocument/publishOutline for that file.
If I then click "Go to Augmented" CodeLens, it opens main.dart, but no outline is ever sent.
I suspect there is some race here, but it's the main reason of hitting the 5s timeout in #5047 and fixing this might be a better way to handle it (because changing the timeout of not waiting is a trade-off with negative consequences noted in microsoft/vscode#208900).
Activity
DanTup commentedon Mar 27, 2024
Fix at https://dart-review.googlesource.com/c/sdk/+/360041
The issue was that an optimization to skip re-analyzing files as they're opened was also resulting in not getting these notifications.
[-]dart/textDocument/publishOutline is not sent for newly opened file[/-][+]dart/textDocument/publishOutline (and other notifications) are not sent for newly opened files, resulting in slow CodeLens (and possibly others)[/+][-]dart/textDocument/publishOutline (and other notifications) are not sent for newly opened files, resulting in slow CodeLens (and possibly others)[/-][+]dart/textDocument/publishOutline (and other notifications) are not sent for newly opened files[/+][analysis_server] Ensure server notifications are sent for newly-open…
DanTup commentedon Mar 27, 2024
Fixed by dart-lang/sdk@41612e4, ships in SDK