Repository navigation
"Cannot read properties of null (reading 'startsWith')" running tests #5930
Description
Running test\src\services\correction\fix\add_static_test.dart with F5 in VS Code, I see this error:
In this code:
const path = maybeUriToFilePath(useRootLocation ? evt.test.root_url : evt.test.url);It appears that evt.test.root_url is undefined but evt.test.url is null, and maybeUriToFilePath handles undefined but not null.
{"seq":2273,"type":"event","body":{"test":{"id":5,"name":"AddStaticTest test_multipleFields","suiteID":0,"groupIDs":[2,3],"metadata":{"skip":true,"skipReason":"does not have \"solo\""},"line":null,"column":null,"url":null},"type":"testStart","time":1055},"event":"dart.testNotification"}
Activity
DanTup commentedon Feb 25, 2026
I'm surprised that we're not getting the location for this, maybe there's also a bug somewhere like
pkg:test?{"seq":2273,"type":"event","body":{"test":{"id":5,"name":"AddStaticTest test_multipleFields","suiteID":0,"groupIDs":[2,3],"metadata":{"skip":true,"skipReason":"does not have "solo""},"line":null,"column":null,"url":null},"type":"testStart","time":1055},"event":"dart.testNotification"}
DanTup commentedon Feb 25, 2026
Handled the nulls, and opened #5931 as a reminder to investigate why we got nulls in this specific case (seems like we should have a location).
DanTup commentedon Mar 2, 2026
I'm reverting this fix because #5938 is arguably worse, but this is still an exception we need to fix, so re-opening this and will re-apply the fix after the release, and think about how to fix #5938 better.
DanTup commentedon Mar 2, 2026
Reverting didn't solve the issue because the skips now have locations and don't trigger the bug. So, I'm keeping this fix in.