Repository navigation
Tests skipped due to solo do not have their locations set correctly #5931
Description
Splitting this from #5930 since it's separate to the fix for handling null properly in Dart-Code.
It appears that evt.test.root_url is undefined but evt.test.url is null, and maybeUriToFilePath handles undefined but not null.
{"seq":2273,"type":"event","body":{"test":{"id":5,"name":"AddStaticTest test_multipleFields","suiteID":0,"groupIDs":[2,3],"metadata":{"skip":true,"skipReason":"does not have \"solo\""},"line":null,"column":null,"url":null},"type":"testStart","time":1055},"event":"dart.testNotification"}
It's not clear to me why we would have nulls here instead of the actual location of the test. Could it be a bug upstream?
Activity
DanTup commentedon Feb 26, 2026
dart-lang/test#2599
DanTup commentedon Feb 26, 2026
PR at dart-lang/test#2600
[-]Skipped tests might not have locations?[/-][+]Tests skipped due to `solo` do not have their locations set correctly[/+]FMorschel commentedon Feb 27, 2026
This has landed on the SDK https://dart-review.googlesource.com/c/sdk/+/483863.
Is this why, when I used
@soloTest, the other test gutter icons vanished?DanTup commentedon Feb 27, 2026
Hmm, I'm not sure, but it sounds very plausible. Try it out and let me know if that doesn't get fixed on latest.
(I'll close this since the fix landed, although users will need to get the latest pkg:test - which hasn't been published yet - to get the fix in their own projects)
FMorschel commentedon Feb 27, 2026
Yes, this is now fixed. But now I see
Skip: does not have "solo"in theTest ResultsandDebug Consolefor every other test. I suspect we were not getting those because we weren't handling them correctly without a location previously (because of #5930).Which test reporter are we using?
DanTup commentedon Feb 27, 2026
It's possible - could you file an issue with a screenshot of what you see?
We're using the json reporter, since we need the output in json so we can parse the tests/groups/etc.
FMorschel commentedon Feb 27, 2026
I've opened #5938