Repository navigation
Handle deep link notifications from new Flutter DAP - #6140
Merged
Merged
Conversation
This is work towards #6134. It also requires a Flutter change (flutter/flutter#190455) and to track down why the DevTools server URL + VM Service URL in the Flutter code are `null` (which prevents the error not being included).
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Aug 3, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
src/test/flutter_debug/flutter_run.test_device.test.ts:641
- The stubbed
showWarningMessagecall arguments are being interpreted incorrectly:args[1]is the first button label (a string), not astring[]. This makes thebuttonsassertion ineffective and can mask failures. Also, the test should wait for the dialog to be shown before asserting, to avoid flakiness.
assert.ok(showInformationMessage.called);
const args = showInformationMessage.getCalls()[0].args;
const message = args[0] as string;
const buttons = args[1] as string[];
assert.ok(message.includes("A RenderFlex overflowed by"));
assert.ok(buttons[0], "Inspect Widget");
});
src/extension/commands/debug.ts:1061
- The
catchblock drops the underlying exception details, which makes it harder to diagnose why a deep link failed to parse. Logging the caught error/stack alongside the URL would provide much better troubleshooting information.
} catch {
this.logger.error(`Failed to parse DevTools deep link URL: ${deepLinkUrl}`);
return undefined;
}
…asses" This reverts commit f77cf60.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work towards #6134. It also requires a Flutter change (flutter/flutter#190455) and to track down why the DevTools server URL + VM Service URL in the Flutter code are
null(which prevents the error not being included).Failing test
The new test will fail until the Flutter change lands and we can guard the test with a version check.