Skip to content

Handle deep link notifications from new Flutter DAP - #6140

Merged
DanTup merged 6 commits into
masterfrom
handle-new-dap-inspector-deep-links
Aug 6, 2026
Merged

DanTup merged 6 commits into
masterfrom
handle-new-dap-inspector-deep-links

Conversation

@DanTup

@DanTup DanTup commented Aug 3, 2026 •

Copy link
Copy Markdown
Member

This is work towards #6134. It also requires a Flutter change (flutter/flutter#190455) and to track down why the DevTools server URL + VM Service URL in the Flutter code are null (which prevents the error not being included).

Failing test

The new test will fail until the Flutter change lands and we can guard the test with a version check.

This is work towards #6134. It also requires a Flutter change (flutter/flutter#190455) and to track down why the DevTools server URL + VM Service URL in the Flutter code are `null` (which prevents the error not being included).
@DanTup DanTup added this to the v3.142.0 milestone Aug 3, 2026
@DanTup DanTup added is bug fix in flutter Relates to running Flutter apps relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available labels Aug 3, 2026
@codecov

This comment was marked as outdated.

This comment was marked as outdated.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

src/test/flutter_debug/flutter_run.test_device.test.ts:641

  • The stubbed showWarningMessage call arguments are being interpreted incorrectly: args[1] is the first button label (a string), not a string[]. This makes the buttons assertion ineffective and can mask failures. Also, the test should wait for the dialog to be shown before asserting, to avoid flakiness.
		assert.ok(showInformationMessage.called);
		const args = showInformationMessage.getCalls()[0].args;
		const message = args[0] as string;
		const buttons = args[1] as string[];
		assert.ok(message.includes("A RenderFlex overflowed by"));
		assert.ok(buttons[0], "Inspect Widget");
	});

src/extension/commands/debug.ts:1061

  • The catch block drops the underlying exception details, which makes it harder to diagnose why a deep link failed to parse. Logging the caught error/stack alongside the URL would provide much better troubleshooting information.
		} catch {
			this.logger.error(`Failed to parse DevTools deep link URL: ${deepLinkUrl}`);
			return undefined;
		}

Comment thread src/test/flutter_debug/flutter_run.test_device.test.ts
@DanTup
DanTup merged commit 28dd757 into master Aug 6, 2026
20 checks passed
@DanTup
DanTup deleted the handle-new-dap-inspector-deep-links branch August 6, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in flutter Relates to running Flutter apps is bug fix relies on sdk changes Something that requires changes in the Dart/Flutter SDK to ship before it will become available

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants