Repository navigation
[flutter_tools] [DAP] Extract and forward DevTools Deep Link URLs to DAP clients - #190455
Merged
auto-submit[bot] merged 4 commits intoAug 5, 2026
Merged
Conversation
…ients This is functionality from the legacy DAPs that was missed when migrating to the SDK. Some kinds of errors (such as Overflow errors) includes nodes to deep-link into DevTools. By forwarding these to the IDE, instead of just a text link the IDE can show a toast notification with a button to open the embedded version of DevTools. This is part of the work to fix Dart-Code/Dart-Code#6134.
github-actions
Bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates FlutterErrorFormatter to extract the error summary and DevTools deep link URL from structured errors, and modifies FlutterDebugAdapter to forward these deep links via a dart.flutter.devToolsDeepLink event. The review feedback suggests using null-coalescing assignment (??=) to prevent nested nodes from overwriting the primary error summary and deep link URL, and requests adding a test to verify that FlutterDebugAdapter correctly forwards the event.
This was referenced Aug 3, 2026
bkonyi
reviewed
Aug 5, 2026
bkonyi
left a comment
bkonyi
left a comment
Contributor
There was a problem hiding this comment.
LGTM overall! Just one nit.
flutter-dashboard
Bot
removed
the
autosubmit
DanTup
added a commit
to Dart-Code/Dart-Code
that referenced
this pull request
Aug 6, 2026
This is work towards #6134. It also requires a Flutter change (flutter/flutter#190455) and to track down why the DevTools server URL + VM Service URL in the Flutter code are `null` (which prevents the error not being included).
This was referenced Aug 6, 2026
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is functionality from the legacy DAPs that was missed when migrating to the SDK. Some kinds of errors (such as Overflow errors) includes nodes to deep-link into DevTools. By forwarding these to the IDE, instead of just a text link the IDE can show a toast notification with a button to open the embedded version of DevTools.
This is part of the work to fix Dart-Code/Dart-Code#6134. There are some additional fixes required elsewhere, but once those are resolved, this will result in a notification like this:
Clicked "Inspect Widget" will open the embedded Inspector on the correct widget.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.