Make dom-mediacapture-record work on TS 4.4's DOM - #54096

@sandersn Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• dom-mediacapture-record — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ❌ Continuous integration tests have failed
• 🕐 Most recent commit is approved by type definition owners or DT maintainers

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 54096,
  "author": "sandersn",
  "headCommitOid": "8c2db45c40a509cb863aef731882fc2a5a7e115b",
  "lastPushDate": "2021-06-25T19:08:24.000Z",
  "lastActivityDate": "2021-06-28T17:57:12.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "dom-mediacapture-record",
      "kind": "edit",
      "files": [
        {
          "path": "types/dom-mediacapture-record/dom-mediacapture-record-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/dom-mediacapture-record/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "elsmr",
        "AppLover69"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 868776388,
  "ciResult": "fail",
  "ciUrl": "https://github.com/DefinitelyTyped/DefinitelyTyped/commit/8c2db45c40a509cb863aef731882fc2a5a7e115b/checks?check_suite_id=3088697205"
}

🔔 @elsmr @AppLover69 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

I just published @types/[email protected] to npm.

This PR removes the type RecordingState and hence the error when I use the new package version:

node_modules/@types/dom-mediacapture-record/index.d.ts:58:21 - error TS2304: Cannot find name 'RecordingState'.

58     readonly state: RecordingState;
                       ~~~~~~~~~~~~~~

Ran into same error over RecordingState although I have not yet located where it was defined before.

@boris-petrov you should only update to the latest if you have TS 4.4, which is still a day from shipping its beta.
You need to specify exact versions of any DOM polyfill package since the types have to match exactly.

In this case, I get can the package to work for all versions of TS by inlining the RecordingState type so that it works with older versions as well. I did that here: #54152