Repository navigation
Add template interceptor type definition - #7928
Conversation
|
rest/rest.d.ts to author (@Nemo157). Could you review this PR? Checklist
|
|
Should the type of |
|
Yeah I wasn't certain about that - I think its more correct though, so will change. Also, with the tests the current ones all have the config type set to And so forth, or is there a reason not to do this? It'd be nice if these types could always be correctly inferred, but I can't seem to get to work. |
|
Actually it does seem to infer the types properly most of the time. With the current incorrect definition it'll infer the config type to be However surprisingly this will compile just fine? So with the tests I could change them to use inference wherever appropriate, and fill out corresponding stub config too. Does this sound reasonable? |
|
Weird that it works with the explicit type... Changing to use inference everywhere would be good, they may have improved the inference since I first added the config checking. |
There was a problem hiding this comment.
Inference doesn't work here
There was a problem hiding this comment.
Ahh, it's failing to derive the correct type for knownConfig as it doesn't have an init method in the config it passes to interceptor. There's probably some way to change the definition of rest/interceptor to allow it to correctly derive it.
|
👍 |
Add template interceptor type definition
- Make DivOverlay / Tooltip interactive (DefinitelyTyped#7531, DefinitelyTyped#7532 by @johnd0e) - Add openOn, close, toggle functions to DivOverlay (DefinitelyTyped#6639 by @johnd0e) - Introduce DomEvent.off(el) to remove all listeners (DefinitelyTyped#7125 by @johnd0e) - Allow preventing round-off errors by passing false to Util.formatNum / toGeoJSON (DefinitelyTyped#7100 by @johnd0e) - Add autoPanOnFocus to Marker (DefinitelyTyped#8042 by @IvanSanchez) - Add referrerPolicy to TileLayer (DefinitelyTyped#7945 by @natevw) - Add playsInline to VideoOverlay (DefinitelyTyped#7928 by @Falke-Design) - Add getCenter to ImageOverlay (DefinitelyTyped#7848 by @Falke-Design) - Fire a tileabort event when a TileLayer load is cancelled (DefinitelyTyped#6786 by @dstndstn) - Add crossOrigin to Icon (DefinitelyTyped#7298 by @syedmuhammadabid)
…ds, as of version 1.8 by @someonewithpc * Leaflet: Update definitions to include missing methods found in 1.8 A declaration was generated with `dts-gen` and compared with the existing definition, merging them manually to add missing methods * Leaflet: Explicitly define `Evented.listens` with the corresponding function type and fix linter errors * Leaflet: Add tests for added methods * Leaflet: Add missing Mixin export * Allow L.geoJSON to accept geojson.GeoJsonObject[], fixing #60930 * Temporarily duplicate the implementation of Events and Evented, so tests pass * Fix toGeoJson(precision?: number | false) argument for all overrides * Add missing properties, as pointed out by DangerBotOSS * Add a 'tileabort' event when a tile load is cancelled See Leaflet/Leaflet#6786 * Make changes reported in Leaflet's Changelog - Make DivOverlay / Tooltip interactive (#7531, #7532 by @johnd0e) - Add openOn, close, toggle functions to DivOverlay (#6639 by @johnd0e) - Introduce DomEvent.off(el) to remove all listeners (#7125 by @johnd0e) - Allow preventing round-off errors by passing false to Util.formatNum / toGeoJSON (#7100 by @johnd0e) - Add autoPanOnFocus to Marker (#8042 by @IvanSanchez) - Add referrerPolicy to TileLayer (#7945 by @natevw) - Add playsInline to VideoOverlay (#7928 by @Falke-Design) - Add getCenter to ImageOverlay (#7848 by @Falke-Design) - Fire a tileabort event when a TileLayer load is cancelled (#6786 by @dstndstn) - Add crossOrigin to Icon (#7298 by @syedmuhammadabid)
4 participants
Adds definition for the template interceptor.
See https://github.com/cujojs/rest/blob/master/docs/interceptors.md#module-rest/interceptor/template