Repository navigation
DYN-10982 Document CI/local parity and single-source build commands - #17379
Merged
Merged
Conversation
Addresses the 2026-10-07 AFC survey findings for Dynamo on master (85 pre-cap, 70 strict): - CI/local parity: AGENTS.md said RS0016/RS0017 "fail the build", but only CI passes /warnAsError:RS0016,RS0017 /p:PublicApiAnalyzers=true; a plain local build only warns. Add the CI-parity build command to Build Commands and the proof checklist, and correct the Blast Radius wording. - Linux: the proof checklist said DynamoCore.sln commands also work on Linux, but build_dynamo_core.yml notes dotnet test discovers no tests there. Say builds work on Linux and tests run on Windows. - Static analysis: state that the analyzer build is the lint step (no separate linter) and where formatting rules live. - Command redundancy: the dynamo-onboarding and dynamo-dotnet-expert skills restated the build commands already mirrored in AGENTS.md and copilot-instructions.md (kept in sync by check_instruction_drift.ps1). They now point at AGENTS.md. - copilot-instructions.md was 258 lines; fold the duplicated API-breaking-changes section into API Compatibility and drop two low-value sections (now 244 lines). - dynamo-skill-writer still used the old src/DynamoCoreTests path; the test/Libraries proof pattern now notes names vary. Drift parity re-checked: 12/12 commands and all four PublicAPI projects match between AGENTS.md and copilot-instructions.md. Co-Authored-By: Claude Opus 5.5 <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://autodesk.atlassian.net/browse/DYN-10982
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The .NET skill’s build/test reference does not point to any test commands and mislabels the core solution.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Aligns developer guidance with actual CI behavior and centralizes build/test command references.
Changes:
- Documents CI-parity builds, analyzer behavior, and platform constraints.
- Consolidates API compatibility guidance.
- Replaces duplicated skill commands with canonical documentation references.
| File | Description |
|---|---|
AGENTS.md |
Adds CI/local parity guidance and corrects platform notes. |
.github/copilot-instructions.md |
Mirrors command guidance and removes duplication. |
.claude/skills/dynamo-skill-writer/SKILL.md |
Corrects the example test-project path. |
.claude/skills/dynamo-onboarding/SKILL.md |
References centralized build/test commands. |
.claude/skills/dynamo-dotnet-expert/SKILL.md |
References centralized guidance, but omits the test section. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… label Review follow-up on #17379: the Tech Stack row promised build and test guidance but linked only to § Build Commands, which has no test invocations, and labeled DynamoCore.sln as the engine solution. It now references both § Build Commands and § After Changes — Proof Checklist (matching dynamo-onboarding) and calls DynamoCore.sln the core solution. Co-Authored-By: Claude Code <[email protected]>
jasonstratton
approved these changes
Oct 7, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-10982 follow-up. A 2026-10-07 re-audit of
master(@8cadc025ed) with the Agent-Friendly Codebase rubric's global caps applied literally scored Dynamo 85 before caps / 70 strict. (The earlier 100/100 had been read from the DYN-10982 branch before it merged in its final form, and didn't apply the caps.) This PR fixes the documentation-side findings. No production code changes.Key changes:
/warnAsError:RS0016,RS0017 /p:PublicApiAnalyzers=true(build_dynamo_all.yml); a plain local build only warns. Added the CI-parity build to Build Commands and the proof checklist, and corrected the Blast Radius wording.DynamoCore.slncommands also work on Linux, butbuild_dynamo_core.ymlnotesdotnet testdiscovers no tests there. It now says builds work on Linux and tests run on Windows.dynamo-onboardinganddynamo-dotnet-expertskills restated the build commands already mirrored inAGENTS.mdandcopilot-instructions.md(kept in sync bycheck_instruction_drift.ps1). They now point atAGENTS.md.dynamo-skill-writerstill used the oldsrc/DynamoCoreTestspath; thetest/Libraries/...proof pattern now notes that names vary (e.g.NodeServicesTest/DynamoServicesTests.csproj).Declarations
Check these if you believe they are true
Release Notes
N/A
Reviewers
@DynamoDS/eidos
Notes to reviewers:
check_instruction_drift.ps1's two checks (no pwsh on the authoring machine): 12/12dotnet/msbuildlines and all four PublicAPI projects match betweenAGENTS.mdandcopilot-instructions.md. CI runs the real gate.FYIs
🤖 Generated with Claude Code