Repository navigation
Fix for migration of newly added default arguments - #7655
Merged
aparajit-pratap merged 6 commits intoApr 20, 2017
Merged
Conversation
…ynamoDS#7623) * update LibG binaries * cherry-pick: update preloader for ASM223 * remove support for LibG220 * update test frameworks to preload appropriate ASM version * remove ASM220 library version * update LibG binaries for newer ASM 223 version used in Revit2018 * fix flaky test case * recover from geometry exceptions thrown during manipulator creation * fix for graph re-execution after changing scaling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Refer #4518. There is a bug in migrating old nodes to newer ones that have added default arguments. The current implementation does not work for instance method nodes, i.e., nodes that have the first argument as the
thisobject. For example:... the
Remeshnode in MeshToolkit library is an instance method that takes in a mesh as its first argument. On adding a new default argument to this method, the old method without arguments failed as the default input port was not enabled upon migration.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@sharadkjaiswal