Repository navigation
Recover from geometry exceptions thrown during manipulator creation - #7623
Merged
aparajit-pratap merged 16 commits intoFeb 21, 2017
Merged
Conversation
…nto RC1.2.3_master
…nto RC1.2.3_master
…nto RC1.2.3_master
…nto RC1.2.3_master
…nto RC1.2.3_master
…nto RC1.2.3_master
…nto RC1.2.3_master
benglin
reviewed
Feb 21, 2017
| liveRunnerServices.ReloadAllLibraries(libraryServices.ImportedLibraries); | ||
| libraryServices.SetLiveCore(LiveRunnerCore); | ||
|
|
||
| codeCompletionServices = new CodeCompletionServices(LiveRunnerCore); |
Contributor
There was a problem hiding this comment.
For some reasons the hidden code part in OnLibraryLoaded cannot be expanded on mobile device, just want to make sure codeCompletionServices is not omitted by mistake.
|
|
||
| dynamoViewModel.ExecuteCommand(new DynamoModel.ForceRunCancelCommand(false, false)); | ||
| var allNodes = dynamoViewModel.HomeSpace.Nodes; | ||
| dynamoViewModel.HomeSpace.MarkNodesAsModifiedAndRequestRun(allNodes, forceExecute: true); |
Contributor
There was a problem hiding this comment.
I think MarkNodesAsModifiedAndRequestRun is an old method, so you have to pass nodes to it (the very same thing that HomeSpace already has access to). It just looks weird, so I'd you're in the position to change it, you might want to consider simplifying it.
Contributor
Author
There was a problem hiding this comment.
I think MarkNodesAsModifiedAndRequestRun takes in nodes as input so that one can choose which nodes to pass to mark as modified.
benglin
approved these changes
Feb 21, 2017
aparajit-pratap
added a commit
to aparajit-pratap/Dynamo
that referenced
this pull request
Feb 22, 2017
…ynamoDS#7623) * update LibG binaries * cherry-pick: update preloader for ASM223 * remove support for LibG220 * update test frameworks to preload appropriate ASM version * remove ASM220 library version * update LibG binaries for newer ASM 223 version used in Revit2018 * fix flaky test case * recover from geometry exceptions thrown during manipulator creation * fix for graph re-execution after changing scaling
aparajit-pratap
added a commit
that referenced
this pull request
Feb 22, 2017
… dirty and force re-execute upon scaling (#7629) * Recover from geometry exceptions thrown during manipulator creation (#7623) * update LibG binaries * cherry-pick: update preloader for ASM223 * remove support for LibG220 * update test frameworks to preload appropriate ASM version * remove ASM220 library version * update LibG binaries for newer ASM 223 version used in Revit2018 * fix flaky test case * recover from geometry exceptions thrown during manipulator creation * fix for graph re-execution after changing scaling * build fix * revert unchanged files
aparajit-pratap
added a commit
that referenced
this pull request
Apr 20, 2017
* Recover from geometry exceptions thrown during manipulator creation (#7623) * update LibG binaries * cherry-pick: update preloader for ASM223 * remove support for LibG220 * update test frameworks to preload appropriate ASM version * remove ASM220 library version * update LibG binaries for newer ASM 223 version used in Revit2018 * fix flaky test case * recover from geometry exceptions thrown during manipulator creation * fix for graph re-execution after changing scaling * build fix * fix for migration of newly added default arguments * reverting unchanged file * added test case for instance node migration on adding default argument
aparajit-pratap
added a commit
that referenced
this pull request
Apr 24, 2017
* Recover from geometry exceptions thrown during manipulator creation (#7623) * update LibG binaries * cherry-pick: update preloader for ASM223 * remove support for LibG220 * update test frameworks to preload appropriate ASM version * remove ASM220 library version * update LibG binaries for newer ASM 223 version used in Revit2018 * fix flaky test case * recover from geometry exceptions thrown during manipulator creation * fix for graph re-execution after changing scaling * build fix * update references to MIConvexHull NuGet package used in Tessellation * added Nuget package config file for MIConvexHull * revert unchanged file * remove xml file
aparajit-pratap
added a commit
that referenced
this pull request
May 24, 2017
* Recover from geometry exceptions thrown during manipulator creation (#7623) * update LibG binaries * cherry-pick: update preloader for ASM223 * remove support for LibG220 * update test frameworks to preload appropriate ASM version * remove ASM220 library version * update LibG binaries for newer ASM 223 version used in Revit2018 * fix flaky test case * recover from geometry exceptions thrown during manipulator creation * fix for graph re-execution after changing scaling * build fix * prevent ExportSAT UI node from executing by default * revert unchanged file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes:
The fix is to catch any such exceptions thrown from the geometry library and display a warning on the manipulator node to the effect that direct manipulation has failed due to reasons mentioned in exception messages handed back from LibG.
Note that the node in warning state continues to run, just that its manipulator fails to generate. If inputs change and the node re-evaluates so that it can successfully generate the manipulator, the warning disappears as expected. If the node is unselected, then too the warning state disappears.
ForceRunCancelcommand to reset the engine and rerun the graph. This caused a crash when running in Revit. The fix is to instead mark all nodes in the graph dirty and force re-execute without resetting the engine. Take a look atDynamoViewModelChangeScaleFactorinDynamoView.xaml.cs.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@benglin
FYIs
@monikaprabhu @riteshchandawar