Skip to content

Add back missing engineController - #7966

Merged
QilongTang merged 1 commit into
masterfrom
MissingEngine
Jun 14, 2017
Merged

QilongTang merged 1 commit into
masterfrom
MissingEngine

Conversation

@QilongTang

Copy link
Copy Markdown
Contributor

Purpose

Add back the missing param of EngineController so that Bindings serialization could be done

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

FYIs

@ikeough

@QilongTang
QilongTang merged commit 4c7aad2 into master Jun 14, 2017
@QilongTang
QilongTang deleted the MissingEngine branch June 14, 2017 19:36
@ikeough

ikeough commented Jun 14, 2017 •

Copy link
Copy Markdown
Contributor

@QilongTang Was this not already handled in #7957?

@QilongTang

QilongTang commented Jun 15, 2017 •

Copy link
Copy Markdown
Contributor Author

@ikeough #7957 Missed passing a param of engineeController causing Bindings serialization to fail for UI saving. This PR just added the param.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants