Skip to content

Before epoch fix - #132

Merged
cowtowncoder merged 8 commits into
FasterXML:masterfrom
kupci:before-epoch-fix
Aug 30, 2019
Merged

cowtowncoder merged 8 commits into
FasterXML:masterfrom
kupci:before-epoch-fix

Conversation

@kupci

@kupci kupci commented Aug 27, 2019

Copy link
Copy Markdown
Member

No description provided.

@kupci

kupci commented Aug 27, 2019

Copy link
Copy Markdown
Member Author

Argh. I may have to switch to command line commits, this GitHub UI is clickity-clickity. Build failed, but that is because GitHub is not syncing up correctly with local changes somehow. Will fix that, and then adjust the 'work-in-progress' to 'ready for review'.

fix serialization/deserialization for ZoneDateTime for times before epoch
@kupci
kupci marked this pull request as ready for review August 27, 2019 04:56
@kupci

kupci commented Aug 27, 2019

Copy link
Copy Markdown
Member Author

Not sure where to specify bug this is associated with: ZonedDateTime for times before the epoch do not serialize correctly 2.10 easy
#69 opened on Apr 9, 2018 by cowtowncoder

@kupci

kupci commented Aug 27, 2019

Copy link
Copy Markdown
Member Author

This also fixes #120

@pjfanning

pjfanning commented Aug 28, 2019 •

Copy link
Copy Markdown
Member

@kupci could you add the test case in #120 (comment) (if this does fix #120)?

@kupci

kupci commented Aug 28, 2019

Copy link
Copy Markdown
Member Author

@kupci could you add the test case in #120 (comment) (if this does fix #120)?

Yes, I've got that test case from the issue included in the test suite.

@pjfanning

Copy link
Copy Markdown
Member

@cowtowncoder this PR looks good to me - do you think it is ok to merge it?

@cowtowncoder

Copy link
Copy Markdown
Member

@pjfanning Ok. So, to get this 2.10 I can... I think I'll merge this, just backport.

@cowtowncoder

Copy link
Copy Markdown
Member

Finally got this merged: thank you everyone for getting this annoying long-time bug fixed.

@kupci
kupci deleted the before-epoch-fix branch September 9, 2019 02:51
joschi added a commit to joschi/jackson-datatype-threetenbp that referenced this pull request Aug 14, 2023
joschi added a commit to joschi/jackson-datatype-threetenbp that referenced this pull request Aug 14, 2023
joschi added a commit to joschi/jackson-datatype-threetenbp that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants