Skip to content

Add support for metrics / tracing #169

Description

@chainlink

Hi,
It would be great to be able to track metrics from the proxy (connections, disconnects, etc) in prometheus. If you're open to a PR on this, I can create one

Activity

  1. hfwang commented on May 31, 2018

    @hfwang
    Contributor

    We intend to add metrics to the proxy, we were thinking of first starting with pushing metrics to stackdriver, but it makes sense to try to make it pluggable so others can write to different places.

  2. changed the title [-]Add prometheus metrics[/-] [+]Feature Request: Add support for metrics (stackdriver, prometheus)[/+] on Jul 16, 2018
  3. hfwang commented on Jul 24, 2018

    @hfwang
    Contributor

    Just wanted to reach back out on this issue, we plan to add monitoring to the proxy client using the OpenCensus library which has pluggable exports.

    Nothing yet that we are ready to show publicly though.

  4. chainlink commented on Jul 24, 2018

    @chainlink
    Author

    Great news! @hfwang any idea on ETA for that?

  5. tanuck commented on Aug 14, 2018

    @tanuck

    If there's work already underway for this, is there an ETA yet?

  6. hfwang commented on Aug 21, 2018

    @hfwang
    Contributor

    We are hoping to have something available in October. The proxy client allows for some interesting setups that are a bit hard to express with the existing stackdriver library, namely reporting metrics to multiple projects simultaneously (as you could connect to instances in different projects), so progress has been a bit slower than expected.

  7. hfwang commented on Nov 15, 2018

    @hfwang
    Contributor

    Sorry for the delay, we had hoped to get something done by October. We had built a prototype, but actually getting it to a releasable state has dragged on quite a bit. We are still working on this though.

  8. oliveiraVG commented on Feb 6, 2019

    @oliveiraVG

    Any updates on this issue?

  9. sergio-fleetsmith commented on Apr 1, 2019

    @sergio-fleetsmith

    Is progress still being made on this front? Would love to have metrics for CloudSQL to see performance and be able to debug potential issues.

  10. kishendas commented on Apr 15, 2019

    @kishendas

    Is there any progress on this one ? We definitely need metrics for CloudSQL, as its in our critical path.

  11. marcosrmendezthd commented on May 8, 2019

    @marcosrmendezthd

    +1

  12. jbradleynh commented on Aug 15, 2019

    @jbradleynh

    Hoping this feature is underway, metrics from cloudsql-proxy would be super valuable

  13. 3 remaining items

  14. kurtisvg commented on Oct 12, 2020

    @kurtisvg
    Contributor

    @bergquist to clarify, the proxy only touches the connection layer (and not the protocol layer).

    You would see metrics around how often connections connect / disconnect but wouldn't see things like what queries were performed or if they were successful for not.

  15. added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Feb 9, 2021
  16. changed the title [-]Feature Request: Add support for metrics (stackdriver, prometheus)[/-] [+]Feature Request: Add support for metrics / tracing[/+] on Feb 10, 2021
  17. enocom commented on Feb 10, 2021

    @enocom
    Member

    Note: this issue likewise includes support for Cloud Trace. See #600 for context.

  18. withnale commented on Apr 23, 2021

    @withnale

    Any update on this? I'd love to see this feature but it seems to keep getting knocked back due to some dependency or other?

    Can we not separate the metrics and tracing cards and get them delivered independently?

  19. enocom commented on Apr 23, 2021

    @enocom
    Member

    I agree this is one of the top feature requests.

    At the moment, we're a little hesitant to add support for metrics and tracing given the state of the two in the Go ecosystem. Presently, we're waiting on two things:

    1. Some major refactoring of the dialer functionality in the proxy (work currently in progress), and
    2. OpenTelemetry to go GA.

    The refactoring will make adding support for metrics and tracing much, much less painful.

  20. changed the title [-]Feature Request: Add support for metrics / tracing[/-] [+]Add support for metrics / tracing[/+] on Sep 30, 2021
  21. enocom commented on Sep 30, 2021

    @enocom
    Member

    See https://github.com/kurtisvg/cloud-sql-go-connector#enabling-tracing where we've added support for tracing and metrics in the new dialer.

  22. enocom commented on Aug 29, 2022

    @enocom
    Member

    The v2 release (currently in public preview) has support for Prometheus, Cloud Monitoring, and Cloud Trace.

    Get the release here: https://github.com/GoogleCloudPlatform/cloud-sql-proxy/releases/tag/v2.0.0.preview.0.

    Docs here: https://github.com/GoogleCloudPlatform/cloud-sql-proxy#support-for-metrics-and-tracing.

  23. self-assigned this
    on Sep 7, 2022
  24. added a commit that references this issue on Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions