Repository navigation
Add support for metrics / tracing #169
Description
Activity
We intend to add metrics to the proxy, we were thinking of first starting with pushing metrics to stackdriver, but it makes sense to try to make it pluggable so others can write to different places.
Reacted by Kyle White, Mitsuhiro Tanda and Pau Ruŀlan Ferragut- changed the title
[-]Add prometheus metrics[/-][+]Feature Request: Add support for metrics (stackdriver, prometheus)[/+]on Jul 16, 2018 - addedtype: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
on Jul 16, 2018 Just wanted to reach back out on this issue, we plan to add monitoring to the proxy client using the OpenCensus library which has pluggable exports.
Nothing yet that we are ready to show publicly though.
Great news! @hfwang any idea on ETA for that?
If there's work already underway for this, is there an ETA yet?
We are hoping to have something available in October. The proxy client allows for some interesting setups that are a bit hard to express with the existing stackdriver library, namely reporting metrics to multiple projects simultaneously (as you could connect to instances in different projects), so progress has been a bit slower than expected.
Reacted by tanuck, Devan Patel and Garrett EverdingSorry for the delay, we had hoped to get something done by October. We had built a prototype, but actually getting it to a releasable state has dragged on quite a bit. We are still working on this though.
Reacted by Kyle White, Arthur, Mario and NaseemAny updates on this issue?
Reacted by Clémence Saussez, maciej-sawicki-codilime, Ry Walker and Simon ElsbrockIs progress still being made on this front? Would love to have metrics for CloudSQL to see performance and be able to debug potential issues.
Reacted by Simon Elsbrock, Juan Ignacio Donoso and Marcus BarczakIs there any progress on this one ? We definitely need metrics for CloudSQL, as its in our critical path.
Reacted by Tobias Flühmann+1
Hoping this feature is underway, metrics from cloudsql-proxy would be super valuable
3 remaining items
@bergquist to clarify, the proxy only touches the connection layer (and not the protocol layer).
You would see metrics around how often connections connect / disconnect but wouldn't see things like what queries were performed or if they were successful for not.
- addedpriority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.
on Feb 9, 2021 - changed the title
[-]Feature Request: Add support for metrics (stackdriver, prometheus)[/-][+]Feature Request: Add support for metrics / tracing[/+]on Feb 10, 2021 Note: this issue likewise includes support for Cloud Trace. See #600 for context.
Reacted by DwightAny update on this? I'd love to see this feature but it seems to keep getting knocked back due to some dependency or other?
Can we not separate the metrics and tracing cards and get them delivered independently?
I agree this is one of the top feature requests.
At the moment, we're a little hesitant to add support for metrics and tracing given the state of the two in the Go ecosystem. Presently, we're waiting on two things:
- Some major refactoring of the dialer functionality in the proxy (work currently in progress), and
- OpenTelemetry to go GA.
The refactoring will make adding support for metrics and tracing much, much less painful.
- changed the title
[-]Feature Request: Add support for metrics / tracing[/-][+]Add support for metrics / tracing[/+]on Sep 30, 2021 See https://github.com/kurtisvg/cloud-sql-go-connector#enabling-tracing where we've added support for tracing and metrics in the new dialer.
The v2 release (currently in public preview) has support for Prometheus, Cloud Monitoring, and Cloud Trace.
Get the release here: https://github.com/GoogleCloudPlatform/cloud-sql-proxy/releases/tag/v2.0.0.preview.0.
Docs here: https://github.com/GoogleCloudPlatform/cloud-sql-proxy#support-for-metrics-and-tracing.
Hi,
It would be great to be able to track metrics from the proxy (connections, disconnects, etc) in prometheus. If you're open to a PR on this, I can create one