Repository navigation
fix: Firebase RTDB event types have ".ref" not ".document" - #79
Merged
matthewrobertson merged 1 commit intoAug 17, 2021
Merged
Conversation
coryan
approved these changes
Aug 17, 2021
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
I know me "approving" does not unblock anything, but since I read the changes I might as well say that they LGTM.
matthewrobertson
approved these changes
Aug 17, 2021
MontyCarter
added a commit
to MontyCarter/functions-framework-php
that referenced
this pull request
Aug 24, 2021
matthewrobertson
pushed a commit
to GoogleCloudPlatform/functions-framework-php
that referenced
this pull request
Aug 25, 2021
* fix: Firebase RTDB event types have ".ref" not ".document" See GoogleCloudPlatform/functions-framework-conformance#79 * Update unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.