Server Error when running PubSub sample

I followed the README at https://github.com/GoogleCloudPlatform/nodejs-docs-samples/appengine/pubsub/

After deploying to App Engine standard, I see in the logs:

A  Error: `line` is not an integer 
A      at Parser.initBlock (/srv/node_modules/pug-parser/index.js:156:36) 
A      at Parser.emptyBlock (/srv/node_modules/pug-parser/index.js:168:17) 
A      at Parser.parseTag (/srv/node_modules/pug-parser/index.js:1040:19) 
A      at Parser.parseExpr (/srv/node_modules/pug-parser/index.js:208:21) 
A      at Parser.parse (/srv/node_modules/pug-parser/index.js:112:25) 
A      at parse (/srv/node_modules/pug-parser/index.js:12:20) 
A      at Object.parse (/srv/node_modules/pug/lib/index.js:125:22) 
A      at Function.loadString [as string] (/srv/node_modules/pug-load/index.js:45:21) 
A      at compileBody (/srv/node_modules/pug/lib/index.js:86:18) 
A      at Object.exports.compile (/srv/node_modules/pug/lib/index.js:242:16)

@steren

Hi @steren. It seems to be a compatibility issue. The samples are checked for standard environment in Feb and on March a routine dependency update (#583 ) bumped the version of package pug from 2.0.0-rc3 to 2.0.0. The sample runs just fine with the old version (2.0.0-rc3). I will update the code to keep it compatible with pug 2.0.0.

Thanks for investigating.
do you know why our integration tests did not catch this?

Seems to be a known bug with pug 2.0.0 (pugjs/pug#2979). Updating to 2.0.1 solves the problem. Sending the PR now.

From my understanding there are still some configuration problems with the CircleCI system :( Ace has migrated some tests to Kokoro and Les has asked us to migrate the rest to Kokoro as well. It shouldn't be a problem soon, I think

Fixed a bug introduced by pug 2.0.0.

Fixed a bug introduced by pug 2.0.0. (#608)

@michaelawyu

I think this got fixed with @michaelawyu 's PR. Closing, feel free to reopen if still needed.

docs(samples): include metadata file, add exclusions for samples to h…

chore: release 4.1.0 (#607)

migrate code from googleapis/nodejs-speech (#2857)

chore(main): release 4.1.0 (#600)

chore: release 3.1.1 (#607)

Navigation Menu

Repository navigation

Server Error when running PubSub sample #607

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Server Error when running PubSub sample #607

Description

Activity

michaelawyu commented on Apr 28, 2018

steren commented on Apr 28, 2018

michaelawyu commented on Apr 28, 2018

michaelawyu commented on Apr 28, 2018

fhinkel commented on Jun 12, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions