Skip to content

Incorrect metadata endpoint in GAE standard sample #616

Closed
Closed
Incorrect metadata endpoint in GAE standard sample#616
Assignees
michaelawyu

Description

@ghost
ghost
opened on May 10, 2018

Issue found in the following file:
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/master/appengine/metadata/standard/server.js#L25

According to the currently documented list of App Engine metadata server endpoints, the endpoint used in this sample (/computeMetadata/v1/instance/network-interfaces) is not available in the App Engine standard environment.

Activity

  1. michaelawyu
    self-assigned this
    on May 10, 2018

  2. michaelawyu commented on May 10, 2018

    @michaelawyu
    michaelawyu
    on May 10, 2018
    Contributor

    I will update this sample to use project-id instead external-ip :)

  3. michaelawyu commented on May 10, 2018

    @michaelawyu
    michaelawyu
    on May 10, 2018
    Contributor

    @ericschmidtatwork PR sent: #617

    I vaguely recall that this sample was updated to use project ID before...

  4. michaelawyu commented on May 23, 2018

    @michaelawyu
    michaelawyu
    on May 23, 2018
    Contributor

    PR merged: #624

  5. michaelawyu
    closed this as completedon May 23, 2018
  6. ace-n
    added 2 commits that reference this issue on Nov 16, 2022

    chore: release 3.4.0 (#616)

    a0ab434

    chore: release 3.4.0 (#616)

    159362c
  7. ahrarmonsur
    added a commit that references this issue on Nov 17, 2022

    chore: release 3.4.0 (#616)

    621a472
  8. Shabirmean
    added a commit that references this issue on Feb 16, 2023

    chore: release 3.1.2 (#616)

    85e7372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions