Repository navigation
Restore the Ruby 4.0.6 upgrade - #4845
Merged
Merged
Conversation
PR #4831 committed a stale Gemfile.lock over the newer one, taking .ruby-version back to 3.2.3 and rolling back active_median, dalli, parallel, rbs and selenium-webdriver. Dockerfile and .devcontainer/Dockerfile still build on Ruby 4, so the Gemfile's version check fails against the image. Restores both files to what they were before that merge. Co-Authored-By: Claude Opus 5 <[email protected]>
This was referenced Sep 22, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Restores the Ruby 4.0.6 upgrade and synchronizes the dependency lockfile.
Changes:
- Restores five gem upgrades.
- Updates Ruby version metadata to 4.0.6.
| File | Description |
|---|---|
Gemfile.lock |
Restores dependency versions and Ruby 4.0.6 metadata. |
.ruby-version |
Sets the project Ruby version to 4.0.6. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Sigh, usually I see those before I whack merge :/ |
CloCkWeRX
added a commit
that referenced
this pull request
Sep 27, 2026
* Restore the Ruby 4.0.6 upgrade (#4845) PR #4831 committed a stale Gemfile.lock over the newer one, taking .ruby-version back to 3.2.3 and rolling back active_median, dalli, parallel, rbs and selenium-webdriver. Dockerfile and .devcontainer/Dockerfile still build on Ruby 4, so the Gemfile's version check fails against the image. Restores both files to what they were before that merge. Co-authored-by: Claude Opus 5 <[email protected]> * Stop avatars shifting the page during feature specs (#4847) * Stop avatars shifting the page during feature specs spec/features/places/searching_a_place_spec.rb intermittently failed on "goes to members' index page": the click on "View all members >>" landed on nothing and the browser stayed put. Member avatars come from gravatar.com over the network and were rendered with img-fluid and no dimensions, so they reserved no space until they arrived. The link sits directly under that grid. Capybara found the link, an avatar landed, the link moved, and the click missed. rails_helper meant to prevent this, but its guard tested for Poltergeist's url_blacklist. Poltergeist is long gone and Selenium's browser has no such method, so the condition was always false and the block never ran. - Give the two avatar image tags explicit width and height, so the box is reserved before the image loads. This fixes real layout shift for members too, not only the specs. - Replace the dead guard with config.x.blank_avatars, which browser specs set, making avatar_uri return a blank inline GIF. Helper specs still assert the real Gravatar URLs. Co-Authored-By: Claude Opus 5 <[email protected]> * Fix avatar URI logic to prevent layout shift in all environments --------- Co-authored-by: Claude Opus 5 <[email protected]> * Upgrade Font Awesome to 6.7.2 (#4846) * Restore the Ruby 4.0.6 upgrade PR #4831 committed a stale Gemfile.lock over the newer one, taking .ruby-version back to 3.2.3 and rolling back active_median, dalli, parallel, rbs and selenium-webdriver. Dockerfile and .devcontainer/Dockerfile still build on Ruby 4, so the Gemfile's version check fails against the image. Restores both files to what they were before that merge. Co-Authored-By: Claude Opus 5 <[email protected]> * Upgrade Font Awesome from 5.15.1 to 6.7.2 Font names have moved on twice since this was pinned: the codebase still carried Font Awesome 4 names that render as an empty box, and FA6 icons such as fa-ellipsis-vertical were unavailable. The 6.x gem no longer ships _font-awesome-sprockets.scss, but its @font-face rules still call fa-font-path(), so application.scss defines that against Sprockets' font-path helper. Its fonts live under assets/fonts/font-awesome, which is already in the precompile list. Icon names: - The bare "fa" prefix is not a style in 6. Every "fa fa-<name>" becomes "fas fa-<name>" (38 call sites, all solid; the one brands icon already used fab). - fa-sun-o was a Font Awesome 4 name and had been rendering as a box; now fa-sun. - fa-pencil was likewise broken under 5, where it was fa-pencil-alt. It exists again in 6, so the existing name now works. - activity_icon asked for 'fa-truck-pickup' through a helper that already adds the prefix, so it emitted "fa-fa-truck-pickup". Verified that the solid, regular and brands fonts all resolve through the asset pipeline. Co-Authored-By: Claude Opus 5 <[email protected]> * couple more places to upgrade font awesome --------- Co-authored-by: Claude Opus 5 <[email protected]> * Add a garden layout page for mapping where plants sit in a bed (#4835) * Share the three-dots button style outside planting rows The round three-dots toggle was scoped to .planting-row. Move it to a generic .actions-toggle-dots so other menus can reuse it. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Show the garden card actions menu as three dots Matches the planting rows, and gives the button an aria-label naming the garden. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Let garden cards update a planting as JSON PATCH /plantings/:slug.json now returns the garden's refreshed card, as create does, or the validation errors as 422. Annual plantings in the card say whether the viewer can edit them. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add a PATCH helper and a shared way to swap in a garden card Co-Authored-By: Claude Sonnet 5 <[email protected]> * Let owners edit the planted date on garden cards The date on an annual planting row is a button with a pencil hint for plantings the viewer can edit. It opens the browser's date picker, saves with the tick or Enter, and swaps in the refreshed card so predictions follow the new date. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Serve a planting's form values as JSON for the edit dialog Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add a shared isPlainClick helper Co-Authored-By: Claude Sonnet 5 <[email protected]> * Edit a planting in a dialog over the garden list Three dots > Edit opens the planting's form in a modal instead of going to the edit page. It saves as JSON and swaps in the refreshed garden card, so the page is never left. Ctrl/cmd-click still opens the edit page. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Drop the garden choice from the planting edit dialog Moving a planting between gardens isn't part of quick editing. The dialog no longer asks, or sends, which garden. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Rate a planting with stars in the edit dialog Overall rating is five clickable stars (real radio buttons underneath, so the keyboard works) with a Clear button, in place of a select. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Only ask for a finished date once a planting is marked finished Co-Authored-By: Claude Sonnet 5 <[email protected]> * Show planting menu items in lowercase Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add an Add planting button to garden cards The way to plant in a garden was an item in its actions menu. Put a green button in the card header, next to the menu, that opens the same dialog. It only shows for gardens you can plant in. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Take Plant something here out of the garden card menu The Add planting button does that now. The card data carries its link as plant_url, instead of it being borrowed from a menu item. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add a gallery page of a member's past gardens /members/:slug/gardens/past shows their inactive gardens as photo cards: when each was in use, how many plantings, and the crops grown in it. The owner (or a collaborator) can mark a garden active again from its card. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Replace the include in-active tickbox with a link to past gardens Co-Authored-By: Claude Sonnet 5 <[email protected]> * Call them inactive gardens, and explain what that page is Rename the past gardens page to inactive gardens throughout (label, route, action, view, styles). Move its link on the gardens page to below the member's card, with a line saying what it holds, and add an explanation to the page itself. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Line the breadcrumb up with the page content The breadcrumb bar is the same colour as the page, but its side padding pushed the text 1rem in from the edge the heading and content sit on. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Line the sidebar text up with the text in the member card The skip link, nav links, button, blurb and inactive gardens link sat at the card's edge while the card's own text is inset. Give them the same inset, left-align the blurb, and add a little space between the links. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Make the sidebar nav links look like links Link colour and underline, with the page you are on in bold and marked aria-current. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Let garden cards record a harvest as JSON GET /plantings/:slug/harvests/new.json gives the form's starting values and choices; POST /harvests.json returns the garden's refreshed card, or the validation errors as 422. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Record a harvest in a dialog over the garden list Three dots > record harvest opens a quick entry form (how many, weight, when, plant part, notes) in a modal, with the crop and today's date filled in. It saves as JSON and swaps in the refreshed card, so the page is never left. Ctrl/cmd-click still opens the full harvest page. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Pass the harvest handler to the planting row, not the perennial chip The record harvest prop had been attached to the first matching element in GardenCard, the perennials' CropChip, so the row's menu item fell through to a normal link. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Share the dialog step indicator Co-Authored-By: Claude Sonnet 5 <[email protected]> * Record a harvest in two steps, styled like Add planting Step 1 is what part you harvested: a big text box, with the cursor in it, that completes from the plant parts (the crop's usual one first). Step 2 is how much: quantity, weight, when and notes, with the choice shown back and a Change button. Same look as the Add planting dialog. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Harvest dialog: add When and Any notes steps, drop Cancel Step 3 is when (Today, Yesterday, or Enter date), step 4 is any notes, and that step saves. The choices so far are shown back with Change buttons, and there is a Back button. Closing the dialog is how you cancel. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Mark the planting that has just had a harvest recorded For a few seconds the row goes amber and gets a Harvest recorded tag, and the notice names the garden, so it is clear which planting it was. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Only offer Yesterday when a harvest then would be after planting The server needs a harvest to come after the planted date, so a planting made today (or yesterday) has no Yesterday, and the date box starts the day after it was planted. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Fix the JSON request specs, and tolerate an empty harvest param The update helper took its hash as keywords, and the form GET sent a JSON content type, which Rails wraps into an empty harvest param that new then rejected. The specs are fixed, and new ignores a blank harvest param. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Put Mark as finished last in the planting menu, below a divider It takes the planting off the list, so it goes after the everyday actions, separated from them. The card menu and the garden page menu match. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Show a tick on the progress bar for each harvest Each harvest is a small tick at its date on the bar's own scale, with the date as a tooltip and a hidden sentence for screen readers. The card data carries the positions, worked out with the same formula as the fill. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Make the pill choice styles general, not about harvests Co-Authored-By: Claude Sonnet 5 <[email protected]> * Let garden cards save seeds as JSON GET /plantings/:slug/seeds/new.json gives the form's starting values and choices; POST /seeds.json returns a link to the new seed, or the validation errors as 422, without queueing a flash message. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Save seeds in a dialog over the garden list Three dots > save seeds opens a dialog in the same style as record harvest: about how many (with quick picks), whether to offer them for trade, and any notes. It saves as JSON and shows a notice with a link to the seeds, so the page is never left. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add feature specs for the save seeds and record harvest dialogs Co-Authored-By: Claude Sonnet 5 <[email protected]> * Let garden cards choose and add a Flickr photo as JSON GET /photos/new.json gives a page of the member's Flickr photos (or says to connect or reconnect Flickr), and POST /photos.json adds one to the planting or garden and returns the garden's refreshed card, or the validation errors as 422. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add a small page for a Flickr connect pop-up to end on /authentications/connected says whether Flickr got connected and closes itself. It has no site header or footer, as it appears in a small window. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add a photo in a dialog over the garden list, connecting Flickr there too Three dots > add photo (on a planting or a garden) opens a dialog: choose one of your Flickr photos by album or tag, confirm it, and it is added without leaving the page, with the garden's card refreshed. If Flickr is not connected, or the connection has expired, the first step connects it in a pop-up and the dialog carries on by itself once it has worked. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add feature specs for the add photo dialog, with Flickr stubbed Co-Authored-By: Claude Sonnet 5 <[email protected]> * Stop handled menu clicks reaching jquery_ujs, and close the menu A menu item that carries a data-method (mark as finished) was still sent as a request by jquery_ujs after a dialog had taken the click over, so the page navigated and the change was made before the dialog could be used. A click a dialog handles is now stopped in the menu, which also closes it. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Mark a planting finished in a dialog, asking when it finished Three dots > mark as finished opens a dialog over the list: when did it finish, today unless you enter a date. Today is not offered for a planting made today, as the server needs a finish after the planting. It saves as JSON and the planting leaves the list, without leaving the page. The card data carries the server's date for today. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add specs for the mark as finished dialog Co-Authored-By: Claude Sonnet 5 <[email protected]> * Make the crop chip the planting's menu, for annuals and perennials Clicking a chip opens the planting's menu under it (view, edit, add photo, record harvest, save seeds, mark as finished), in place of the three dots on annual rows, so perennials get the same menu. A caret shows the chip opens something. Someone who can't change the planting still gets a plain link chip. The menu items are lowercase for every planting menu. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Update the garden index spec for chip menus An owner's planting chip is a menu now, with a View link to the planting. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Let garden cards edit a garden as JSON GET /gardens/:slug/edit.json gives the form's values and choices, and PATCH /gardens/:slug.json returns the garden's refreshed card, or the validation errors as 422, without queueing a flash message. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Edit a garden in a dialog over the garden list Three dots on a garden card > edit opens its form in a dialog, and saves without leaving the page. A garden saved as inactive leaves the list, with a note saying where it went. Co-Authored-By: Claude Sonnet 5 <[email protected]> * Add feature specs for the edit garden dialog Co-Authored-By: Claude Sonnet 5 <[email protected]> * Update the edit garden spec: Edit on a card opens the dialog Co-Authored-By: Claude Sonnet 5 <[email protected]> * Re-dump schema.rb under Rails 8.1 Rails 8.1's schema dumper sorts each table's columns alphabetically, and schema.rb was last dumped under 8.0, so the next migration rewrites the whole file. Doing that on its own here, with no schema changes, keeps the garden layout commit's schema diff down to what it actually adds. The lines are identical to before, only reordered. Co-Authored-By: Claude Opus 5 <[email protected]> * Add a garden layout page for mapping where plants sit in a bed A new page at /members/:member_slug/gardens/:slug/layout shows the bed as a grid, and the garden cards link to it as "Garden layout". Each planting in the sidebar is a crop chip. Dragging it onto the bed places one plant there, and the chip stays so it can be dragged again; dragging a plant back to the sidebar takes it off the bed. Plants can go anywhere on the bed, not just in a cell, and are drawn as circles with the crop's icon. The owner can change the bed's size above it, and it redraws as they type. There is also a "Remove all" button, and a "Plant something" button that opens the same dialog as the garden cards. Plants are a new model, one row per individual plant in a planting, so a planting of ten tomatoes is ten plants that are placed one at a time. That also gives per-plant state, such as one plant failing, somewhere to go later. A planting's quantity now follows its number of plants, and existing plantings are backfilled with one plant each per plant they say they have, up to 100. The layout saves the whole arrangement in one request, in a transaction, so a bad placement leaves the bed as it was. The owner and collaborators can arrange plants; only the owner can resize the bed or plant into it. The members-nested gardens routes now use :slug, like the top-level ones. They used :id, which the controller's loader never read, so those routes could not find a garden; nothing linked to them. The specs are not up to date with the Plant model yet, and have not been run: the layout request, serializer and feature specs still describe earlier versions of the page. Co-Authored-By: Claude Opus 5 <[email protected]> * Add a compost bin to the garden layout, and make the bed look like soil Dragging a plant into the compost bin deletes it, so its planting has one fewer; dropping it anywhere else in the sidebar still just lifts it off the bed. The save request carries the composted plant ids, since a plant missing from the arrangement otherwise means lifted, not gone. The plant arcs into the bin as it's dropped, unless the viewer prefers reduced motion. The bin sits under "About this garden", drawn there through a portal so it stays part of the layout island, and is sticky so it stays in reach on a long bed. There is no compost icon in the Icons8 set, so it uses the earth worm. The bed is now dark soil in a timber frame, with the grid as twine. The frame is the border, so drops are measured against the soil inside it. The sidebar is just the crop chips now, without a status line under each. Co-Authored-By: Claude Opus 5 <[email protected]> * Let plants on the garden layout be resized, and make dragging easier Each plant can be drawn bigger or smaller, since a tomato takes more room than basil: drag the handle on its edge. plants.diameter holds the size in grid cells once a plant is resized; until then it follows its crop's new default_diameter, or the parent crop's, or one cell. There is no form for crop defaults yet. The next plant taken off a planting's chip is the size last given to one of its plants, so shrinking one chive shrinks the next. Dragging is easier to follow. The browser's own drag picture all but vanished on the soil, so a ringed circle at the plant's size follows the pointer instead, centred where it will land. Only a plant's circle picks it up, not the square around it, which overlapped neighbouring plants and could pick up the wrong one. Clicking a plant no longer opens its planting. A crop chip dropped in the compost bin composts one of that planting's unplaced plants. Drag state is now cleared on any drop, since a plant composted from the bed is gone before its own drag end would fire, which left the bin highlighted. Co-Authored-By: Claude Opus 5 <[email protected]> * Point people at the garden layout, and tidy its crop chips The garden page has a card inviting people to the layout, with a small bed drawn in the same soil and timber: "Try out the new garden layout tool" for those who can arrange it, "Open the garden layout" for everyone else. It isn't shown for inactive gardens, which have nothing growing to place. On the gardens list the layout link is now a small "Layout" button beside "Add planting", rather than a line of text under the owner. The sidebar's crop chips are all the width of the sidebar, with the icon inside the chip (the shared chip style pulled it half outside) and the counts lined up. Plantings are listed by crop name, then date, then id; by date alone, plantings made the same day came back in no fixed order and reshuffled whenever a save touched them. A crop in the bed more than once shows each planting's date, so they can be told apart. Co-Authored-By: Claude Opus 5 <[email protected]> * Make a planting's plants when its garden's layout is used, not up front Most plantings will never go on a layout, so giving every planting a row per plant, when it was made and by backfilling the existing ones, filled the plants table for nothing. Now a garden's growing plantings get their plants the first time someone who can arrange the bed opens its layout, in one insert; someone only looking makes none. The backfill migration is gone, so there is nothing to run on deploy. A planting's quantity only adds or removes plants once it is on a layout. Zero now means no plants rather than one, so a planting composted down to nothing isn't given a fresh plant next time the layout is opened; a blank quantity still counts as one. Co-Authored-By: Claude Opus 5 <[email protected]> * Bring the garden layout specs up to date The specs described the layout as it was several versions ago, with positions and spans on plantings. They now cover plants: where they can sit, their sizes and the fallback to the parent crop's, the 100-plant cap, and being made when a layout is first used. The request specs cover saving an arrangement, dragging off a chip, composting, resizing the bed, and who may do each. The feature spec drives the page in a browser. The garden page's layout card and the layout's save route have specs too. Co-Authored-By: Claude Opus 5 <[email protected]> * Tell people about the garden layout at the top of the home page A card at the top of the home page, with the same small drawn bed as the garden page's, invites people to the layout. A signed-in member is sent to the layout of their active garden with the most growing in it, so there is something to arrange, alphabetically between ones with the same. A member with no active garden is asked to add one, and anyone signed out to sign up. Co-Authored-By: Claude Opus 5 <[email protected]> * Keep plants wholly on the garden layout's bed A plant's position is its centre, so a big plant near the edge hung over the timber frame, and ones along the bottom were cut off. Now a plant always stays half its width from each edge: when it's dropped, resized, or the arrangement is saved. Plants already hanging over are drawn pulled in, and saved that way on the next change. A plant can't be made wider than the bed, and shrinking the bed counts each plant's edge, not just its centre. Co-Authored-By: Claude Opus 5 <[email protected]> * Make it easier to tell plants apart on the garden layout Every plant was a circle with its crop's icon, and many crops share an icon or have none, so a bed could be a field of identical sprouts. - A plant big enough on screen carries its crop's name beneath it. - Pointing at a plant, or at a planting's chip in the sidebar, picks out all of that planting's plants and fades the rest. - Plantings drawn with the same icon get a coloured ring, with a matching dot on their chip. There are five colours, which are the ones that stay distinguishable from each other against the soil for every pair, colour blind or not. They go to the plantings that share an icon in the order those were made, so a planting keeps its colour. Past five in one group, plantings go by their names. The layout's data now says which icon each planting is drawn with, so the page can group them. Co-Authored-By: Claude Opus 5 <[email protected]> * Put stepping stones, labels and rows on the garden layout A "Garden features" group in the layout's sidebar has three things to drag onto the bed besides plants: - A stepping stone: a grey pebble, moved by dragging. - A label, such as "path" or "N": asks what it should say, sits over the plants like a marker, and is renamed by double-clicking it. - A row: a furrow two cells long, whose ends can be dragged to set where it runs, moved by the handle at its middle, and optionally named. Any of them goes in the compost bin to be removed. They're kept as a list on the garden, gardens.layout_features, and saved in the same request as the plants, so a bad one rolls back the whole save. They're checked and written directly rather than by saving the garden, which would geocode it on every drag. A save that doesn't send them leaves them alone, and the bed can't be shrunk out from under one. Co-Authored-By: Claude Opus 5 <[email protected]> * Put the garden layout's sidebar on the left, next to the bed The bed sits at the start of its column, sized to fit the window, so a tall, narrow bed left the sidebar stranded far off to its right. With the plantings and garden features on the left, the bed is always right next to them. On a phone they still stack, with the list under the bed. Co-Authored-By: Claude Opus 5 <[email protected]> * Call the garden layout's planting button "Add a planting" Co-Authored-By: Claude Opus 5 <[email protected]> * Add sprinklers, taps, stakes, paths, drip lines, fences, trellises and netting More garden features to put on the layout besides plants: - Points: an irrigation sprinkler and a tap (their Icons8 icons on a white disc ringed in blue), and a stake (the round top of a post). - Lines, drawn and reshaped like rows: a path (a wide gravel strip), a drip line (a thin blue pipe with emitters), a fence (a rail with posts) and a trellis (a strip of timber lattice). - An area: netting, a see-through mesh over the plants it covers, between two corners that can be dragged to resize it. Lines and netting share their handles: the middle to move and name it, the ends or corners to reshape it. The types are now one table in the layout, each with a name and a shape (point, label, line or area), and the sidebar offers them from it. The server knows them by the same split, checks both points of every line and area, and sends the icons as one set, feature_icon_urls. Co-Authored-By: Claude Opus 5 <[email protected]> * Call the garden layout's "Remove all" button "Clear bed" It still lifts only the plants back to their chips; the confirmation now says that stones, lines, netting and the rest stay where they are. Co-Authored-By: Claude Opus 5 <[email protected]> * Put garden features in a toolbar above the bed, and keep the sidebar in view With eleven garden features under the plantings, the sidebar no longer fit on the screen. The features are now a row of small tiles above the bed, in groups (ground, water, supports, markers), each named when pointed at, and the sidebar is just the plantings. The sidebar also stays in view as a tall bed is scrolled, scrolling itself if the list of plantings is long. On a phone it still sits under the bed. Co-Authored-By: Claude Opus 5 <[email protected]> * Implement bed resizing functionality with drag support * Style the garden layout bed's edges, so they can be dragged The bed's right edge, bottom edge and corner had their drag handling but no styles, so they had no size or position and couldn't be grabbed. Now they sit over the timber frame, with a pale grip showing while the bed is pointed at, and a dashed outline shows the size the bed is being dragged to. The bed's column no longer clips, so that outline can show past it when the bed is dragged bigger. Co-Authored-By: Claude Opus 5 <[email protected]> * Bring two garden layout feature specs up to date A chip dropped in the middle of the bed lands within a fraction of a pixel of the middle, not exactly on it. And shrinking the bed past something on it now says "things", as stones and fences count too, not "plants". Co-Authored-By: Claude Opus 5 <[email protected]> * Wait for a garden to be reactivated before checking it "Mark as active" sends the change in the background, and the spec looked at the garden straight after clicking, so it failed whenever the request hadn't finished yet. It now waits for the page to come back first. Co-Authored-By: Claude Opus 5 <[email protected]> --------- Co-authored-by: Claude Sonnet 5 <[email protected]> Co-authored-by: Daniel O'Connor <[email protected]> --------- Co-authored-by: Claude Opus 5 <[email protected]> Co-authored-by: Daniel O'Connor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4831 committed an old Gemfile.lock over the newer one. That put
.ruby-versionback to 3.2.3 and rolled back five gems.Both Dockerfiles still say Ruby 4, so the Gemfile's version check fails and
bundlewon't run.This puts both files back to how they were before that merge.
Assisted by Claude