Skip to content

Fix SvgScript NPE when script engine not available. - #155

Merged
rbri merged 3 commits into
HtmlUnit:masterfrom
shapiroronny:master
Apr 13, 2020
Merged

Fix SvgScript NPE when script engine not available.#155
rbri merged 3 commits into
HtmlUnit:masterfrom
shapiroronny:master

Conversation

@shapiroronny

@shapiroronny shapiroronny commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

Fixing a NPE when parsing an SvgScript when the Script Engine had not been initialized.

Here's the stacktrace :

	at com.gargoylesoftware.htmlunit.html.ScriptElementSupport$1.execute(ScriptElementSupport.java:84)
	at com.gargoylesoftware.htmlunit.html.ScriptElementSupport.onAllChildrenAddedToPage(ScriptElementSupport.java:108)
	at com.gargoylesoftware.htmlunit.svg.SvgScript.onAllChildrenAddedToPage(SvgScript.java:106)
	at com.gargoylesoftware.htmlunit.html.parser.neko.HtmlUnitNekoDOMBuilder.endElement(HtmlUnitNekoDOMBuilder.java:559)
	at org.apache.xerces.parsers.AbstractSAXParser.endElement(Unknown Source)
	at com.gargoylesoftware.htmlunit.html.parser.neko.HtmlUnitNekoDOMBuilder.endElement(HtmlUnitNekoDOMBuilder.java:513)
	at net.sourceforge.htmlunit.cyberneko.HTMLTagBalancer.callEndElement(HTMLTagBalancer.java:1192)
	at net.sourceforge.htmlunit.cyberneko.HTMLTagBalancer.endElement(HTMLTagBalancer.java:1132)
	at net.sourceforge.htmlunit.cyberneko.filters.DefaultFilter.endElement(DefaultFilter.java:219)
	at net.sourceforge.htmlunit.cyberneko.filters.NamespaceBinder.endElement(NamespaceBinder.java:312)
	at net.sourceforge.htmlunit.cyberneko.HTMLScanner$ContentScanner.scanEndElement(HTMLScanner.java:3189)
	at net.sourceforge.htmlunit.cyberneko.HTMLScanner$ContentScanner.scan(HTMLScanner.java:2114)
	at net.sourceforge.htmlunit.cyberneko.HTMLScanner.scanDocument(HTMLScanner.java:937)
	at net.sourceforge.htmlunit.cyberneko.HTMLConfiguration.parse(HTMLConfiguration.java:443)
	at net.sourceforge.htmlunit.cyberneko.HTMLConfiguration.parse(HTMLConfiguration.java:394)
	at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
	at com.gargoylesoftware.htmlunit.html.parser.neko.HtmlUnitNekoDOMBuilder.parse(HtmlUnitNekoDOMBuilder.java:758)
	at com.gargoylesoftware.htmlunit.html.parser.neko.HtmlUnitNekoHtmlParser.parse(HtmlUnitNekoHtmlParser.java:236)
	at com.gargoylesoftware.htmlunit.html.parser.neko.HtmlUnitNekoHtmlParser.parseHtml(HtmlUnitNekoHtmlParser.java:179)```

rbri
rbri reviewed Apr 13, 2020
View reviewed changes

@rbri rbri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, many thanks.
Can you please add your name to the authors section in the source files and also add yourself as contributor to the pom (at last position).

@shapiroronny
shapiroronny requested a review from rbri April 13, 2020 15:00
@rbri
rbri merged commit 5707943 into HtmlUnit:master Apr 13, 2020
@rbri

rbri commented Apr 13, 2020

Copy link
Copy Markdown
Member

Many thanks for your contribution.

rbri added a commit that referenced this pull request Apr 14, 2020
@rbri @shapiroronny
Fix SvgScript NPE when script engine not available. (#155)
d247660 
* Fix SvgScript NPE when script engine not available.
* Update contributors list.
* Update authors.
Co-authored-by: ronnyshapiro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbri rbri Awaiting requested review from rbri

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shapiroronny @rbri