Repository navigation
Rename Method as part of Refactoring - #465
Merged
rbri merged 4 commits intoMar 27, 2022
Merged
Conversation
bharatwaaj
changed the title
rbri
requested changes
Mar 26, 2022
| */ | ||
| public static boolean selects(final BrowserVersion browserVersion, final Selector selector, | ||
| final DomElement element, final String pseudoElement, final boolean fromQuerySelectorAll) { | ||
| public static boolean selectsSpecifiedElement(final BrowserVersion browserVersion, final Selector selector, |
Member
There was a problem hiding this comment.
you are right, better naming might be a good idea but this method is public and i do not want to break the interface here.
| public static boolean selects(final BrowserVersion browserVersion, final Selector selector, | ||
| final DomElement element, final String pseudoElement, final boolean fromQuerySelectorAll) { | ||
| public static boolean selectsSpecifiedElement(final BrowserVersion browserVersion, final Selector selector, | ||
| final DomElement element, final String pseudoElement, final boolean fromQuerySelectorAll) { |
Member
There was a problem hiding this comment.
I guess this reformating breaks the formating rules
Member
|
see comments, please revert the renaming, and please add your name to the contributor list in the pom, |
Contributor
Author
Hi, I have reverted the renaming and added my name to contributor list in the pom.xml, thanks a ton! |
Member
|
Many thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring: Rename Method
Reason for change:
The method selects a specified element based on the parameterized condition. So, the function name must be clearly mentioned as selectSpecifiedElement rather than just selects.From select
To selectSpecifiedElement