Repository navigation
Fixes for building on AArch64 with Clang - #314
Merged
Merged
Conversation
ararslan
commented
Jan 7, 2025
One change in PR 305 was not quite right: it changed a check for whether `$(ARCH)` is `aarch64` to a check for whether it's `aarch64 riscv64`, which can never be true. It was a non-functional change on RISC-V (since it can't be true) but broke AArch64, at least for FreeBSD. Notably, changing the check to what I assume was intended, i.e. `aarch64` or `riscv64`, breaks RISC-V. So this commit instead reverts this one change in 305.
Move the unconditional `?=` definitions below all conditional definitions so that conditional `?=`s can take precedence. Also forcibly set `USEGCC=0` when `USECLANG=1`, otherwise the things guarded behind `USEGCC=1` will be visible. Without these changes, `gmake` on FreeBSD AArch64 incorrectly uses gcc instead of clang.
ararslan
force-pushed
the
aa/clang-aarch64-fixes
branch
from
January 7, 2025 21:14
8f0fd2c to
4d2d83f
Compare
giordano
approved these changes
Jan 7, 2025
giordano
left a comment
giordano
left a comment
Member
There was a problem hiding this comment.
Looks good to me as far as I can tell, the ifeq test was definitely wrong (it could never be true)
ViralBShah
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Jan 8, 2025
This fixes building on FreeBSD AArch64, as there was a regression in OpenLibm 0.8.4; see JuliaMath/openlibm#314.
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Mar 31, 2025
This fixes building on FreeBSD AArch64, as there was a regression in OpenLibm 0.8.4; see JuliaMath/openlibm#314. (cherry picked from commit 3c7bc45)
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Mar 31, 2025
This fixes building on FreeBSD AArch64, as there was a regression in OpenLibm 0.8.4; see JuliaMath/openlibm#314. (cherry picked from commit 3c7bc45)
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Mar 31, 2025
This fixes building on FreeBSD AArch64, as there was a regression in OpenLibm 0.8.4; see JuliaMath/openlibm#314. (cherry picked from commit 3c7bc45)
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Mar 31, 2025
This fixes building on FreeBSD AArch64, as there was a regression in OpenLibm 0.8.4; see JuliaMath/openlibm#314. (cherry picked from commit 3c7bc45)
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Jun 5, 2025
This fixes building on FreeBSD AArch64, as there was a regression in OpenLibm 0.8.4; see JuliaMath/openlibm#314. (cherry picked from commit 3c7bc45)
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Jul 3, 2025
This fixes building on FreeBSD AArch64, as there was a regression in OpenLibm 0.8.4; see JuliaMath/openlibm#314. (cherry picked from commit 3c7bc45)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit messages for descriptions and motivations of changes. We should tag a new patch version after this is merged.