Repository navigation
Change undefined argument handling in Layer[Group]/hasLayer() - #6999
Merged
Merged
Conversation
johnd0e
force-pushed
the
haslayer-notallow-undefined
branch
2 times, most recently
from
February 18, 2020 14:57
b90cab6 to
576032c
Compare
johnd0e
marked this pull request as ready for review
February 18, 2020 14:59
Collaborator
Author
|
May be better leave corresponding tests, if it's possible to express exception as expected result. |
IvanSanchez
approved these changes
Feb 18, 2020
IvanSanchez
left a comment
IvanSanchez
left a comment
Member
There was a problem hiding this comment.
LGTM. I'll leave this unmerged for some time, to see if any other maintainer has any objections to the change in behaviour.
johnd0e
force-pushed
the
haslayer-notallow-undefined
branch
from
January 31, 2021 12:36
576032c to
c7e2bbb
Compare
mourner
approved these changes
Nov 5, 2021
Member
|
Looks there are still some conflicts? |
…/hasLayer() undefined/null/false are not considered as special case anymore, `layer` argument is always required, as per docs. Previous excessive tolerance may lead to real errors get masked.
johnd0e
force-pushed
the
haslayer-notallow-undefined
branch
from
November 5, 2021 12:01
c7e2bbb to
71e1438
Compare
Collaborator
Author
Fixed! |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undefined/null/falseare not considered as special case anymore,layerargument is always required, as per docs.Previous excessive tolerance may lead to real errors get masked.
I've tracked the issue down to it's origin: #1282, but found mentioned there reasons weak.