Repository navigation
TfLite Mul adds missing datatype support - #45
Merged
RahulSundarMCW merged 2 commits intoApr 1, 2025
Merged
RahulSundarMCW merged 2 commits into
RahulSundarMCW merged 2 commits into
Conversation
nitheshsrikanth-mcw
commented
Jul 29, 2024
nitheshsrikanth-mcw
commented
Collaborator
- Adds f16,bf16 for mul
- Adds f16,bf16 unit tests
LukeBoyer
requested changes
Aug 1, 2024
nitheshsrikanth-mcw
force-pushed
the
nithesh_tflite_mul_op_missing_datatype
branch
from
August 16, 2024 09:21
80a5e85 to
d78e99d
Compare
nitheshsrikanth-mcw
force-pushed
the
nithesh_tflite_mul_op_missing_datatype
branch
3 times, most recently
from
August 26, 2024 11:43
9d95900 to
7ab407c
Compare
Collaborator
|
Hi Luke, I wanted to discuss the current status of mul test file, which has now exceeded 780 lines due to the addition of tests for f16 and bf16 to cover the same behavior as f32. Given the significant increase in file size, I'm considering whether it's necessary to test all f32 scenarios for f16 and bf16, or if we might focus on a more selective set of tests. |
amrinfathima-mcw
force-pushed
the
nithesh_tflite_mul_op_missing_datatype
branch
from
August 26, 2024 13:15
7ab407c to
6967706
Compare
- Adds f16,bf16 for mul - Adds f16,bf16 unit tests Addressed review comments and included optimized versions of Mul for bf16/f16 -Adds optimized versions for bf16/f16 mul operation -Addressed review comments -Included the EIGEN_TFLITE flag and other changes to resolve CONV Error
nitheshsrikanth-mcw
force-pushed
the
nithesh_tflite_mul_op_missing_datatype
branch
from
October 24, 2024 03:57
6967706 to
841f474
Compare
Collaborator
Author
|
Hi luke, I have squashed the commits and addressed the changes. |
vamsimanchala
approved these changes
Feb 2, 2025
vamsimanchala
requested changes
Feb 2, 2025
vamsimanchala
approved these changes
Feb 4, 2025
RahulSundarMCW
added a commit
that referenced
this pull request
Apr 1, 2025
* TfLite Mul add missing datatype support - Adds f16,bf16 for mul - Adds f16,bf16 unit tests Addressed review comments and included optimized versions of Mul for bf16/f16 -Adds optimized versions for bf16/f16 mul operation -Addressed review comments -Included the EIGEN_TFLITE flag and other changes to resolve CONV Error * Include non-quantized int8 type support --------- Co-authored-by: nitheshsrikanth-mcw <[email protected]>
RahulSundarMCW
added a commit
that referenced
this pull request
May 7, 2025
* feat: add missing type support for tflite_add (#107) (#108) * TfLite add missing datatype support - Adds bf16, f16 support sub function - Adds bf16, f16 unit tests * Add non-quantized int8 type support and tests * Include check for broadcasting * Tflite sign missing datatype support (#37) (#109) * Tflite sign missing datatype support -Adds i16,f16,bf16 for tflite sign -Adds i16,f16,bf16 tflite sign unit tests * Add non-quantized int8 type support --------- Co-authored-by: swatheesh-mcw <[email protected]> * TfLite_sub_op add missing datatype support (#35) (#110) * TfLite sub missing datatype support - Adds bf16, f16 support sub function - Adds bf16, f16 unit tests * Include non-quantized int8&int16 type support * Tflite ceil missing datatypes support (#51) (#111) * Tflite ceil missing datatypes support -Adds bf16,f16,i8,i16,i32 for tflite ceil operations -Adds bf16,f16,i8,i16,i32 ceil unit tests * Add unquantized int8 support --------- Co-authored-by: abhinav <[email protected]> * TfLite Mul adds missing datatype support (#45) * TfLite Mul add missing datatype support - Adds f16,bf16 for mul - Adds f16,bf16 unit tests Addressed review comments and included optimized versions of Mul for bf16/f16 -Adds optimized versions for bf16/f16 mul operation -Addressed review comments -Included the EIGEN_TFLITE flag and other changes to resolve CONV Error * Include non-quantized int8 type support --------- Co-authored-by: RahulSudarMCW <[email protected]> --------- Co-authored-by: swatheesh-mcw <[email protected]> Co-authored-by: abhinav <[email protected]> Co-authored-by: nitheshsrikanth-mcw <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.