Repository navigation
Accept attempts exhausted in the lifecycle churn contract, and say which Qdrant operations filter on the incarnation - #1775
Merged
edwinyyyu merged 2 commits intoOct 7, 2026
Conversation
create_collection and open_or_create_collection document VectorStoreAttemptsExhaustedError as the outcome of creation races that make no progress, and the Qdrant store's own churn test already accepts it. The contract's churn test refused it, so it could fail on a documented outcome. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
The design said every search, scroll, and delete of a handle filters on the incarnation. A handle's deletes name its points' derived ids, with no filter; the scrolls and filtered deletes are the purge's. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
edwinyyyu
added
the
horizontal scaling
This was referenced Oct 7, 2026
Draft
[session storage 2/2] Remove open-or-create from both stores, and close from the segment store
#1625
Draft
[qdrant options] Let a deployment tune a Qdrant collection's HNSW, optimizers and quantization
#1618
Draft
edwinyyyu
merged commit Oct 7, 2026
d45d8dd
into
MemMachine:feat/horizontal-scaling
39 checks passed
edwinyyyu
added a commit
to edwinyyyu/MemMachine
that referenced
this pull request
Oct 7, 2026
…ich Qdrant operations filter on the incarnation (MemMachine#1775) * Accept an attempts-exhausted error in the lifecycle churn contract create_collection and open_or_create_collection document VectorStoreAttemptsExhaustedError as the outcome of creation races that make no progress, and the Qdrant store's own churn test already accepts it. The contract's churn test refused it, so it could fail on a documented outcome. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> * Say which Qdrant operations filter on the incarnation The design said every search, scroll, and delete of a handle filters on the incarnation. A handle's deletes name its points' derived ids, with no filter; the scrolls and filtered deletes are the purge's. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> --------- Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
edwinyyyu
removed
the
horizontal scaling
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Summary
Two corrections to #1735. Independent of #1736; either can merge first.
test_lifecycle_churn_raises_only_domain_errorsnow acceptsVectorStoreAttemptsExhaustedError, whichcreate_collectionandopen_or_create_collectiondocument as the outcome of creation races that make no progress. The Qdrant store's own churn test already accepts it; the contract's test could fail on a documented outcome.Commits
Stack
19 open PRs: one independent PR, and the vector store tree of short parallel branches. #1736's and #1775's GitHub base is
feat/horizontal-scalingand the others' ismain, since the branches are in a fork and a pull request can target only this repository's branches; the on column gives the order the PRs build on each other instead. A stacked PR's diff on GitHub includes the PRs under it until they merge.Independent of the vector store tree, directly on
main:mainThe vector store tree. Each PR builds on the one in its on column; PRs on the same parent are parallel branches and do not depend on each other. #1631 is closed, superseded by #1733–#1736, which hold its changes split in four, with review changes since. #1670 and #1702 sit beneath #1627, whose code depends on them. Until the PRs under it merge, their changes show in a stacked PR's diff.
mainfeat/horizontal-scaling)feat/horizontal-scalingfeat/horizontal-scaling)feat/horizontal-scalingfeat/horizontal-scaling)feat/horizontal-scalingfeat/horizontal-scalingfeat/horizontal-scalingThis PR is its 2 commits,
1218f18dc,ba9f952db, directly onfeat/horizontal-scaling.Verification
At the head:
ruff check,ruff format --check, andty checkare clean; the full server suite without integration tests passes (2076 passed, 8 skipped); in test containers, the integration tests pass (1453 passed, 266 skipped), the churn tests among them against Qdrant 1.19.1 over REST and gRPC. Commit 2 changes documentation only.🤖 Generated with Claude Code