Skip to content

Curate internal/ before its imports are rewritten again #518

Open

Description

@David-Noble-at-work

A move is the moment to stop carrying things. Rewriting import lines is the cheapest opportunity this
repository gets to ask, per package, whether it should exist at all -- and a package deleted after the
sweep pays the import rewrite twice.

Recorded so far

  • internal/pwsh -- deleted. Zero importers, a second process-execution path beside pkg/process
    (which declares itself the single bridge to os/exec), and its own package-doc example called a
    constructor that did not exist.
  • internal/tools/docgen -- folded into cmd/devlore-docs, its only importer. internal/tools/ is gone.

Undecided

Five packages remain at the repository root, each needing a keep / replace / delete verdict with its reason:

Package Question
console A second presentation layer with one consumer, while everything else narrates through pkg/status.
credentials Keystore access is solved by maintained libraries; does ours do something they do not?
document Keep -- moves to cmd/internal/document; its pkg/ dependency dissolved when op took trace persistence.
manifest Keep, presumed.
registry Keep, presumed -- OCI registry access is product logic.

"Nothing imports it" is evidence, not a verdict: test harnesses are legitimately importer-less. The test is
whether removing it changes anything a user can observe.

Exit

Every package above carries a recorded verdict; deletions and replacements land before the rename
window, not after.

Charter: 55-curate-internal.md


Epic: #451 · Feature: #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Epic:WorkflowRenameRename op to workflow, then partition ittaskImplementation work item

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions