Repository navigation
feature(op): Export Marshal/UnmarshalToAny, style compliance (Phase 4) - #212
Merged
Merged
Conversation
Export marshal as Marshal and unmarshalToAny as UnmarshalToAny in pkg/op/starvalue_marshal.go for use by noblefactor-ops. Update all internal call sites to use exported names. Add Parameters/Returns doc comments to all exported and unexported helpers across 14 production files touched in Phases 1-4. Add doc comments to unexported struct types (receiverEntry, typeInfo, fieldInfo). Fix sort order: UnmarshalToAny (exported) before unmarshal (unexported). Phase 4 of shared-provider-receivers plan.
4 tasks done
David-Noble-at-work
added a commit
that referenced
this pull request
Jul 28, 2026
… the stated mechanism (#302) The #300 live proof cut both ways: the --admin merge worked (site PR #211, merged by the app with checks pending and zero reviews), then the very next run's merge died on a GitHub 502 and stranded site PR #212 open with green checks. All three sync merges (docs, install script, registry knowledge) now run in a bounded retry loop — 5 attempts, 10/20/30/40s backoff — that consults the PR state before retrying, since a 5xx can arrive after the merge landed server-side. The registry merge also gains --admin: devlore-registry develop sits under the same org ruleset, and the plain merge already failed live — registry PR #69 was app-created, its Knowledge Extract run failed on the merge step, and the PR was merged by hand two minutes later. Comments corrected: --admin disarms gh's client-side merge-state veto; the server-side entitlement is the automation app's "always" bypass on the org ruleset, not repository admin rights. Correction noted in docs/plans/ci-admin-merge-sync-prs.md. Workflow-only change; the live proof is the next sync chain run. Plan: docs/plans/ci-sync-merge-retry.md. Co-authored-by: David Noble <[email protected]>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marshal→MarshalandunmarshalToAny→UnmarshalToAnyinpkg/op/starvalue_marshal.goso noblefactor-ops can replace its parallelstarlarkToGo/goToStarlarkimplementationspkg/op/output.go,pkg/op/receiver_reflect.go, test files)receiverEntry,typeInfo,fieldInfo)Part of the shared-provider-receivers plan. Phases 1-3 merged in #210, #211. Phase 5 follows.
Test plan
make buildpassesmake testpasses (all packages)