Repository navigation
refactor(complexity): phase 1 — writ commands and the test harness - #313
Merged
Merged
Conversation
First phase of the complexity plan (#312): six functions under the thresholds by behavior-preserving decomposition. The three writ Executes (upgrade 30, deploy 22, decommission 23) settle onto one narrative shape — group into scope graphs, emit the dry-run YAML stream, run and collect per-scope failures — via per-package unexported helpers; the now verbatim-identical emitter is flagged in the plan doc as an available dedup ruling, deliberately not taken unilaterally. upgrade's classifyEntry (21) splits its encrypted-chain and render arms; deploy's buildScopeGraph closure (29) extracts splitManifests/planManifests/planChains; devlore-test's TestContext.Check (32) becomes a uniform per-kind dispatch matching the existing check-helper family. Zero complexity findings remain in the touched files; no new findings anywhere; make vet and full make test pass unmodified; gofmt clean. Plan: docs/plans/complexity-refactors.md (phase 1 complete).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of docs/plans/complexity-refactors.md (#312): six functions decomposed under gocognit 20 / gocyclo 15, behavior-preserving — the suite passes unmodified. The three writ
Executes share one narrative shape via per-package helpers (buildScopeGraphs/emitGraphs/runAll); the verbatim-identical emitter is flagged in the plan doc as an available cross-package dedup ruling.classifyEntrysplits its encrypted-chain and render arms; deploy's plan closure extracts manifest/chain planning;TestContext.Checkbecomes uniform per-kind dispatch. Plan doc rides along with phase 1 marked complete.