Bug

Fixes: Infrastructure

Description

For NuGet's publishing of pipeline artifacts from CI, append Job Attempt numbers to more artifact names.
This reduces the incidence of permanently failing a build when the first failed (Attempt # 1) publishes logs, so subsequent attempts are unable to re-publish those logs.

This artifact publishing step will now have an attempt number:

• LocValidation: Publish Logs as an artifact (this recently happened and inspired this change)

When re-running can still fail

• There are still some NuGet steps that rely on a hard-coded artifact name during release. (eg, nupkgs - RTM).
• There are also SBOM generation jobs that publish artifacts without a JobAttempt (eg, BuildConfiguration), but we don't control this YML.
• Publish BootstrapperInfo.json as a build artifact
• Publish NuGet.exe and VSIX as artifact Backup Build Artifacts depends on this name:

  NuGet.Client/eng/pipelines/backup_build_artifacts.yml

  Lines 29 to 46 in 579b09a

  	- task: DownloadPipelineArtifact@2
  	displayName: 'Download product NonRTM'
  	continueOnError: true # in case build didn't publish this artifact
  	inputs:
  	buildType: specific
  	project: $(resources.pipeline.officialbuild.projectID)
  	definition: $(resources.pipeline.officialbuild.pipelineID)
  	artifactName: 'VS15'
  	targetPath: $(Build.ArtifactStagingDirectory)/backup/VS15
  	- task: DownloadPipelineArtifact@2
  	displayName: 'Download product RTM'
  	continueOnError: true # in case build didn't publish this artifact
  	inputs:
  	buildType: specific
  	project: $(resources.pipeline.officialbuild.projectID)
  	definition: $(resources.pipeline.officialbuild.pipelineID)
  	artifactName: 'VS15-RTM'

PR Checklist

• Meaningful title, helpful description and a linked NuGet/Home issue
• Added tests
• Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.