Repository navigation
Update Type Hint Annotations for Consistency - #586
Merged
StanczakDominik merged 3 commits intoDec 11, 2018
Merged
Conversation
Jac0bDeal
commented
Dec 10, 2018
Jac0bDeal
commented
Contributor
- Closes Improve consistency in type hint annotations #572
StanczakDominik
approved these changes
Dec 11, 2018
StanczakDominik
left a comment
StanczakDominik
left a comment
Member
There was a problem hiding this comment.
While tests are blowing up, they're blowing up on master due to something recent and astropy-related and we just hadn't noticed. These changes aren't the cause and look good, so I'll merge them now. Thanks for dealing with this! 😄
| * `Sean Chambers <https://github.com/schambers>`__ | ||
| * `Apoorv Choubey <https://github.com/apooravc>`__ | ||
| * `cclauss <https://github.com/cclauss>`__ | ||
| * `Jacob Deal <https://github.com/Jac0bDeal>`__ |
Member
There was a problem hiding this comment.
Thanks for remembering to do this! 😄 I always forget to remind people to add themselves.
Contributor
Author
There was a problem hiding this comment.
Awesome! Glad to be of service!
StanczakDominik
added a commit
to StanczakDominik/PlasmaPy
that referenced
this pull request
Jan 4, 2019
This reverts commit a481743
StanczakDominik
added a commit
to StanczakDominik/PlasmaPy
that referenced
this pull request
Jan 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.