Repository navigation
Test against astropy and numpy dev versions - #590
Closed
StanczakDominik wants to merge 2 commits into
Closed
StanczakDominik wants to merge 2 commits into
StanczakDominik wants to merge 2 commits into
Conversation
Member
Author
|
That looks like it went like we want it to (see https://travis-ci.org/PlasmaPy/PlasmaPy/builds/470169559?utm_source=github_status&utm_medium=notification ). Following Sunpy, I set it to only run tests with dev versions of Numpy and Astropy during cron tests (every day, but not on PR commits). Tests are still failing due to #587, which I have no idea how to fix barring waiting for astropy 3.1.1. |
Member
That's a good idea! |
StanczakDominik
added a commit
to StanczakDominik/PlasmaPy
that referenced
this pull request
Jan 4, 2019
This brings back the change from PlasmaPy#590, which got obsoleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This, along with f8fac84 which I accidentally pushed to master (shields back online, my mistake), should close #589.